CONTRIB: Enable UCX build for EFA with common sha1 - #395
Merged
Merged
Conversation
Signed-off-by: Thomas Vegas <tvegas@nvidia.com>
|
👋 Hi tvegas1! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
aranadive
reviewed
May 28, 2025
brminich
reviewed
May 28, 2025
brminich
reviewed
May 28, 2025
Signed-off-by: Thomas Vegas <tvegas@nvidia.com>
aranadive
approved these changes
May 28, 2025
brminich
reviewed
May 28, 2025
yosefe
approved these changes
May 29, 2025
Contributor
|
@tvegas1 can we merge? |
Contributor
Author
|
pending the merge of openucx/ucx#10704 |
Signed-off-by: Thomas Vegas <tvegas@nvidia.com>
Signed-off-by: Thomas Vegas <tvegas@nvidia.com>
Contributor
Author
|
ready for merge |
brminich
approved these changes
Jun 3, 2025
aranadive
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
--ucx-upstreamoption to build container with UCX with EFA SRD support.