Skip to content

Agent: Improve MD fetch and invalidate flow in ETCD mode using watchers - #303

Merged
aranadive merged 10 commits into
ai-dynamo:mainfrom
yanivz-nv:etcd
May 21, 2025
Merged

Agent: Improve MD fetch and invalidate flow in ETCD mode using watchers#303
aranadive merged 10 commits into
ai-dynamo:mainfrom
yanivz-nv:etcd

Conversation

@yanivz-nv

@yanivz-nv yanivz-nv commented May 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Refactor commWorker to move all ETCD functionality into new class nixlEtcdClient.
  • When watching for specific key we try to fetch, avoid trying to loadRemoteMD on deletion events.
  • Implement timeout when setting a watcher after trying to fetch a non-existing key.
  • Setup watchers on prefix of remote agent after fetching its metadata.
  • invalidateLocalMD will remove all keys with agent's prefix, then all remote watchers will be notified and invalidateRemoteMD.
  • Relevant tests depend on PR 315

@github-actions

github-actions Bot commented May 13, 2025

Copy link
Copy Markdown

👋 Hi yanivz-nv! Thank you for contributing to ai-dynamo/nixl.

Your PR reviewers will review your contribution then trigger the CI to test your changes.

🚀

@yanivz-nv
yanivz-nv requested review from aranadive and mkhazraee May 18, 2025 05:45
@yanivz-nv

yanivz-nv commented May 19, 2025

Copy link
Copy Markdown
Contributor Author

For tests need to first merge PR #315.

aranadive
aranadive reviewed May 19, 2025
View reviewed changes
Comment thread src/core/nixl_listener.cpp Outdated
etoledano
etoledano reviewed May 20, 2025
View reviewed changes
Comment thread src/core/nixl_listener.cpp Outdated
Comment thread src/core/nixl_listener.cpp
Comment thread src/core/nixl_listener.cpp Outdated
aranadive
aranadive reviewed May 21, 2025
View reviewed changes
Comment thread src/core/nixl_listener.cpp Outdated
aranadive
aranadive reviewed May 21, 2025
View reviewed changes
Comment thread src/core/nixl_listener.cpp Outdated
aranadive
aranadive reviewed May 21, 2025
View reviewed changes
Comment thread src/core/nixl_listener.cpp Outdated
@yanivz-nv
Updated agent watcher lambda: event type check
2e8069d 
Signed-off-by: Yaniv Zegerson <yanivz@nvidia.com>
@aranadive

aranadive commented May 21, 2025

Copy link
Copy Markdown
Contributor

/ok to test 3264b68

@svc-nixl svc-nixl mentioned this pull request Oct 11, 2026
Merged

This branch was previously deployed

2 inactive deployments
GITLAB — 3264b689 Deployed May 21, 2025 by copy-pr-bot[bot]
SWX_AWS — 3264b689 Deployed May 21, 2025 by copy-pr-bot[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etoledano etoledano etoledano left review comments
@aranadive aranadive aranadive approved these changes
@mkhazraee mkhazraee Awaiting requested review from mkhazraee

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yanivz-nv @aranadive @etoledano