Skip to content

POSIX: Add more logs - #235

Merged
tstamler merged 4 commits into
ai-dynamo:mainfrom
tvegas1:posix_plugin_logs
May 7, 2025
Merged

tstamler merged 4 commits into
ai-dynamo:mainfrom
tvegas1:posix_plugin_logs

Conversation

@tvegas1

@tvegas1 tvegas1 commented May 2, 2025

Copy link
Copy Markdown
Contributor

Some nodes might not support io_uring. Add more related details to CI and code.

Signed-off-by: Thomas Vegas <tvegas@nvidia.com>
@github-actions

github-actions Bot commented May 2, 2025

Copy link
Copy Markdown

👋 Hi tvegas1! Thank you for contributing to ai-dynamo/nixl.

Your PR reviewers will review your contribution then trigger the CI to test your changes.

🚀

@tvegas1

tvegas1 commented May 2, 2025

Copy link
Copy Markdown
Contributor Author

@tstamler, wondering if some CI nodes might be missing io_uring support as some related failures were seen?

Comment thread src/plugins/posix/posix_backend.h Outdated
@tstamler

tstamler commented May 5, 2025

Copy link
Copy Markdown
Contributor

@tstamler, wondering if some CI nodes might be missing io_uring support as some related failures were seen?

Yes, I think there is a problem with some Gitlab workers not exposing io_uring system calls correctly. I need to follow up with the Ops team that setup the Gitlab CI but this will also hopefully be fixed when moving to purely Github workers for CI.

@tstamler

tstamler commented May 6, 2025

Copy link
Copy Markdown
Contributor

/ok to test 4bd8625

@copy-pr-bot

copy-pr-bot Bot commented May 7, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: Thomas Vegas <tvegas@nvidia.com>
@tstamler
tstamler merged commit 620bc45 into ai-dynamo:main May 7, 2025
vvenkates27 pushed a commit that referenced this pull request May 8, 2025
* POSIX: Add more logs

---------

Signed-off-by: Thomas Vegas <tvegas@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants