Repository navigation
ci: Move sanitizer base images from Harbor to Artifactory - #2317
Conversation
Push and pull the nixl-ci-test-sanitizers base images from Artifactory (sw-nbu-swx-nixl-docker-local/ci) like the other CI base images. The existing cleanup rule for ci/** base images already covers them. Signed-off-by: NirWolfer <nwolfer@nvidia.com>
|
👋 Hi NirWolfer! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
|
/build |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: ai-dynamo/nixl/.coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe sanitizer job now pulls its image from NVIDIA Artifactory and uses the Artifactory pull secret in Kubernetes. ChangesSanitizer Image Registry
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The sanitizer registry migration follows the existing CI configuration convention. No actionable merge-blocking issue is established; merge after normal CI checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
Move the
nixl-ci-test-sanitizersbase images (-asan/-tsan) from Harbor to Artifactory, matching the other CI base images (#1688).Changes
test-sanitizer-matrix.yaml: switchregistry_host/registry_auth/registry_pathtoartifactory.nvidia.com,svc-nixl-new-artifactory-token,/sw-nbu-swx-nixl-docker-local/ciartifactory-pull-secretimage pull secret to the Kubernetes configci/x86_64/, already covered by theci/**base-image rule in.ci/cleanup-spec.jsonSummary by CodeRabbit