Skip to content

ci: Move sanitizer base images from Harbor to Artifactory - #2317

Merged
NirWolfer merged 1 commit into
ai-dynamo:mainfrom
NirWolfer:sanitizer-image-artifactory
Oct 4, 2026
Merged

NirWolfer merged 1 commit into
ai-dynamo:mainfrom
NirWolfer:sanitizer-image-artifactory

Conversation

@NirWolfer

@NirWolfer NirWolfer commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Move the nixl-ci-test-sanitizers base images (-asan / -tsan) from Harbor to Artifactory, matching the other CI base images (#1688).

Changes

  • test-sanitizer-matrix.yaml: switch registry_host / registry_auth / registry_path to artifactory.nvidia.com, svc-nixl-new-artifactory-token, /sw-nbu-swx-nixl-docker-local/ci
  • Add the artifactory-pull-secret image pull secret to the Kubernetes config
  • No cleanup change needed: the images land under ci/x86_64/, already covered by the ci/** base-image rule in .ci/cleanup-spec.json

Summary by CodeRabbit

  • Chores
    • Updated the sanitizer test environment’s container image source and pull credentials. This affects automated testing infrastructure; no changes to end-user features or behavior.

Push and pull the nixl-ci-test-sanitizers base images from Artifactory
(sw-nbu-swx-nixl-docker-local/ci) like the other CI base images. The
existing cleanup rule for ci/** base images already covers them.

Signed-off-by: NirWolfer <nwolfer@nvidia.com>
@NirWolfer
NirWolfer requested a review from a team as a code owner October 1, 2026 14:15
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

👋 Hi NirWolfer! Thank you for contributing to ai-dynamo/nixl.

Your PR reviewers will review your contribution then trigger the CI to test your changes.

🚀

@NirWolfer

Copy link
Copy Markdown
Contributor Author

/build

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: ai-dynamo/nixl/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: d861cacc-6d4f-41e1-a285-68314a59762f

📥 Commits

Reviewing files that changed from the base of the PR and between df92e41 and 430083a.

📒 Files selected for processing (1)
  • .ci/jenkins/lib/test-sanitizer-matrix.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The sanitizer job now pulls its image from NVIDIA Artifactory and uses the Artifactory pull secret in Kubernetes.

Changes

Sanitizer Image Registry

Layer / File(s) Summary
Sanitizer image source and pull authentication
.ci/jenkins/lib/test-sanitizer-matrix.yaml
The job’s registry host, credential, and image path now use NVIDIA Artifactory values. Kubernetes image pulls use artifactory-pull-secret.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: alexey-rivkin

Merge Risk: ⚪ Minimal · up to 43008

The sanitizer registry migration follows the existing CI configuration convention. No actionable merge-blocking issue is established; merge after normal CI checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: moving sanitizer base images from Harbor to Artifactory.
Description check ✅ Passed The description explains what changed, why the images moved, and how the configuration was updated. It uses Summary and Changes headings instead of the template headings, but it provides the required …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@NirWolfer
NirWolfer merged commit 27153aa into ai-dynamo:main Oct 4, 2026
22 checks passed
@NirWolfer
NirWolfer deleted the sanitizer-image-artifactory branch October 4, 2026 07:56

This branch was previously deployed

1 inactive deployment
SWX_AWS — 430083a7 Deployed Oct 1, 2026 by copy-pr-bot[bot] via Run AWS Tests #9620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants