Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .ci/dockerfiles/Dockerfile.rocm
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,14 @@ ENV PIP_CERT=${SYSTEM_CA_BUNDLE} \
# libgrpc_plugin_support.so from /opt/nixl/lib. Every stage inherits this ENV.
ENV LD_LIBRARY_PATH="${NIXL_INSTALL_DIR}/lib:${NIXL_INSTALL_DIR}/lib64:/usr/local/lib:/usr/local/lib64"

# Force CMake to always copy files in install directives, rather than skip based on file modification timestamp.
# File modification timestamp check in CMake uses 1 second resolution.
# This causes problems for fast builds that install, patch then reinstall the same file, as the final install step
# may be incorrectly skipped.
# Seen in CI as flaky ASAN failure due to inconsistent Azure SDK headers causing memory corruption.
# Inherited by every *-build stage and `final`.
ENV CMAKE_INSTALL_ALWAYS=1
Comment thread
coderabbitai[bot] marked this conversation as resolved.

# Some ROCm base images ship broken cmake configs for these.
RUN rm -rf /usr/lib/cmake/grpc /usr/lib/cmake/protobuf

Expand Down
7 changes: 7 additions & 0 deletions .gitlab/build-rocm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,13 @@ set -e
set -x
set -o pipefail

# Force CMake to always copy files in install directives, rather than skip based on file modification timestamp.
# File modification timestamp check in CMake uses 1 second resolution.
# This causes problems for fast builds that install, patch then reinstall the same file, as the final install step
# may be incorrectly skipped.
# Seen in CI as flaky ASAN failure due to inconsistent Azure SDK headers causing memory corruption.
export CMAKE_INSTALL_ALWAYS=1

# Parse commandline arguments with first argument being the install directory
# and second argument being the UCX installation directory.
# Source dependency options grouped with dep download/build/install steps.
Expand Down
7 changes: 7 additions & 0 deletions .gitlab/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ set -e
set -x
set -o pipefail

# Force CMake to always copy files in install directives, rather than skip based on file modification timestamp.
# File modification timestamp check in CMake uses 1 second resolution.
# This causes problems for fast builds that install, patch then reinstall the same file, as the final install step
# may be incorrectly skipped.
# Seen in CI as flaky ASAN failure due to inconsistent Azure SDK headers causing memory corruption.
export CMAKE_INSTALL_ALWAYS=1

# Parse commandline arguments with first argument being the install directory
# and second argument being the UCX installation directory.
INSTALL_DIR=$1
Expand Down
7 changes: 7 additions & 0 deletions contrib/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,13 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get -y install \

WORKDIR /workspace

# Force CMake to always copy files in install directives, rather than skip based on file modification timestamp.
# File modification timestamp check in CMake uses 1 second resolution.
# This causes problems for fast builds that install, patch then reinstall the same file, as the final install step
# may be incorrectly skipped.
# Seen in CI as flaky ASAN failure due to inconsistent Azure SDK headers causing memory corruption.
ENV CMAKE_INSTALL_ALWAYS=1
Comment thread
tvegas1 marked this conversation as resolved.

# Build Abseil from source (required for absl/log).
RUN git clone https://github.com/abseil/abseil-cpp.git && \
cd abseil-cpp && \
Expand Down
9 changes: 9 additions & 0 deletions contrib/Dockerfile.manylinux
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,15 @@ ENV PATH=/opt/rh/gcc-toolset-14/root/usr/bin:${PATH} \
# cmake_minimum_required(VERSION < 3.5). Some bundled deps (e.g. gRPC's c-ares)
# still declare ancient minimums. This tells CMake 4.x to accept them.
ENV CMAKE_POLICY_VERSION_MINIMUM=3.5

# Force CMake to always copy files in install directives, rather than skip based on file modification timestamp.
# File modification timestamp check in CMake uses 1 second resolution.
# This causes problems for fast builds that install, patch then reinstall the same file, as the final install step
# may be incorrectly skipped.
# Seen in CI as flaky ASAN failure due to inconsistent Azure SDK headers causing memory corruption.
# Inherited by the wheel stage below via FROM $wheel_base.
ENV CMAKE_INSTALL_ALWAYS=1

# === end Option B header ======================================================
ARG LIBFABRIC_VERSION="v1.21.0"
ARG HWLOC_VERSION="2.12.2"
Expand Down
Loading