Repository navigation
Conversation
Signed-off-by: Raul Akhmetshin <rakhmetshin@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe NIXL UCX backend initialization now sets ChangesUCX configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a narrowly scoped change to disable the CUDA IPC cache, with no actionable merge-blocking risk remaining beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/build |
itayalroy
left a comment
There was a problem hiding this comment.
IIUC, connect_ranks relies on the UCX CUDA IPC cache, it destroys the old mview and creates a new one assuming the NVLink ptrs exported during the creation of the old mview are still valid. We cannot disable the cache until we get rid of this assumption. I'm already working on it so should have a PR up soon, so I think we should wait with merging #2089 until then
Do you mean that there will be an issue if |
|
@LinoyGeva and I are seeing intermittent NIXL EP timeouts with vLLM Elastic EP when vLLM also uses the NIXL host API for EPLB weight transfers, so this environment variable disables the IPC cache for the separate EPLB agent as well. We suspect the timeouts are related to that. We cannot merge this PR until we fix this issue. I think it will be easier to fix the memory leak with |
What?
Disabled UCX CUDA IPC cache.
Why?
The previous fix of memory leak (#1846) was reverted (#1996).
These changes (openucx/ucx#11288, openucx/ucx#11730) help eliminate the memory leak by disabling CUDA IPC cache.