Repository navigation
Conversation
|
👋 Hi hxieustc! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
This was referenced Oct 1, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The gRPC clone step used
git clone --recurse-submodules --shallow-submodules, which attempts to fetch the bundledthird_party/abseil-cppsubmodule from GitHub. This fails in environments where the abseil repo is not accessible, even though abseil is already built and installed from source earlier in the same Dockerfile (-DgRPC_ABSL_PROVIDER=packagetells CMake to use it).There were two bugs in the fix attempt:
git -c submodule.<path>.update=nonedoesn't handle slashes in subsection names — git rejects the config key and prints usage.--shallow-submodulesis a git clone flag only, not valid for git submodule update.Fix
Clone gRPC without submodules, then:
.git/configsubmodule."third_party/abseil-cpp".update = nonevia git config (the correct way to handle paths with slashes)git submodule update --recursive --depth 1— abseil is skipped, all other submodules (e.g. protobuf) are fetched normallyTest
Full bash ./build.sh succeeds and produces nixlbench:v1.3.1.dev..