Skip to content

fix(nixlbench): dockerfile fix for abseil failure - #2078

Draft
hxieustc wants to merge 2 commits into
ai-dynamo:mainfrom
hxieustc:harryx/dockerfile-fix-abseil
Draft

hxieustc wants to merge 2 commits into
ai-dynamo:mainfrom
hxieustc:harryx/dockerfile-fix-abseil

Conversation

@hxieustc

Copy link
Copy Markdown
Contributor

Problem

The gRPC clone step used git clone --recurse-submodules --shallow-submodules, which attempts to fetch the bundled third_party/abseil-cpp submodule from GitHub. This fails in environments where the abseil repo is not accessible, even though abseil is already built and installed from source earlier in the same Dockerfile (-DgRPC_ABSL_PROVIDER=package tells CMake to use it).

There were two bugs in the fix attempt:

  1. git -c submodule.<path>.update=none doesn't handle slashes in subsection names — git rejects the config key and prints usage.
  2. --shallow-submodules is a git clone flag only, not valid for git submodule update.

Fix

Clone gRPC without submodules, then:

  1. Run git submodule init to register submodules in .git/config
  2. Set submodule."third_party/abseil-cpp".update = none via git config (the correct way to handle paths with slashes)
  3. Run git submodule update --recursive --depth 1 — abseil is skipped, all other submodules (e.g. protobuf) are fetched normally

Test

Full bash ./build.sh succeeds and produces nixlbench:v1.3.1.dev..

@copy-pr-bot

copy-pr-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown

👋 Hi hxieustc! Thank you for contributing to ai-dynamo/nixl.

Your PR reviewers will review your contribution then trigger the CI to test your changes.

🚀

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants