Skip to content

telemetry: avoid DOCA counter event name allocation #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
e-eygin wants to merge 2 commits into from
Closed

telemetry: avoid DOCA counter event name allocation #1886

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee0e9c6
telemetry: avoid DOCA counter event name allocation
e-eygin Jul 4, 2026
9ed5bfa
telemetry: reflow DOCA counter call to satisfy clang-format
e-eygin Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/plugins/telemetry/doca/doca_exporter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,16 +286,12 @@ nixlTelemetryDocaExporter::appendCounterSample(const nixlTelemetryEvent &event,
const char *label_values[]) {
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
const std::string event_name(nixlEnumStrings::telemetryEventTypeStr(event.eventType_));
const char *event_name = nixlEnumStrings::telemetryEventTypeStr(event.eventType_).data();

@ColinNV ColinNV Jul 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling data() on a string_view and using the result as C-string should not be done, even in this case where the views happen to be, for now (!), constructed from C-strings, it's just such an anti-pattern. Perhaps return C-strings from the enum-to-name function?

// Counter events carry a per-operation delta; increment so the exported
// counter is a monotonic cumulative total (add_counter would instead push
// each delta as an absolute value, yielding a non-monotonic series).
return doca_telemetry_exporter_metrics_add_counter_increment(ctx_->source,
docaTimestamp(),
event_name.c_str(),
event.value_,
ctx_->label_set_id,
label_values);
return doca_telemetry_exporter_metrics_add_counter_increment(
ctx_->source, docaTimestamp(), event_name, event.value_, ctx_->label_set_id, label_values);
#pragma GCC diagnostic pop
}

Expand Down
Loading