build: fix build-container flow (pass --torch-versions in Dockerfile and set explicit EP meson overrides) - #1866
Conversation
|
👋 Hi lishapira! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
`override_options` in meson treats buildtype, optimization, and debug as independent knobs. Setting only `buildtype=release` on the EP target is not always enough to keep --device-debug (-G) off the EP nvcc line under a global --buildtype=debug. Be explicit about all three so the EP target is built without -G regardless of the surrounding context. EP kernels need more registers than the 128-register limit -G imposes.
Dockerfile.manylinux, but left contrib/Dockerfile calling --build-nixl-ep alone. So every EP container build has since errored at the wheel step with "--build-nixl-ep requires --torch-versions". Mirror the manylinux default (WHL_TORCH_VERSIONS=2.11,2.12,2.13) so the EP wheel step completes.
dc3f316 to
9e501e4
Compare
|
/ok to test 9e501e4 |
|
/build |
|
commit 9e501e4 passed on nixl-ci-dl-gpu-ep https://nbuprod.blsm.nvidia.com/nbu-swx-nixl-main/job/nixl-ci-dl-gpu-ep/34/ |
|
commit 9e501e4 passed on nixl-ci-build-container: |
📝 WalkthroughWalkthroughThis PR adds a ChangesBuild Configuration Updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…and set explicit EP meson overrides) (#1866) (#1872) Cherry pick of #1866 Fixes for nixl-ci-build-container flow 1. contrib/Dockerfile: add a new WHL_TORCH_VERSIONS build arg (default 2.11,2.12,2.13, mirroring Dockerfile.manylinux) and forward it to contrib/build-wheel.sh via --torch-versions when BUILD_NIXL_EP=true. 2. examples/device/ep/meson.build: extend the EP target's override_options from ['buildtype=release'] to ['buildtype=release', 'optimization=3', 'debug=false']. After #1802 + #1775 landed, nixl-ci-build-container (debug, BUILD_NIXL_EP=true) has been failing in two distinct places: 1. Wheel step failure: #1775 added --torch-versions support to contrib/build-wheel.sh and updated Dockerfile.manylinux, but contrib/Dockerfile was still calling --build-nixl-ep alone. Every EP container build errored at the wheel step with --build-nixl-ep requires --torch-versions. 2. EP nvcc compile failure: #1802 sets nixl_ep target with override_options = ['buildtype=release'] so a global --buildtype=debug doesn't drop -G onto the EP nvcc line. In practice --device-debug still reached the EP .cu compiles on nixl-ci-build-containe compilation path. Co-authored-by: lishapira <lishapira@nvidia.com>
Fixes for nixl-ci-build-container flow
What?
Why?
After #1802 + #1775 landed, nixl-ci-build-container (debug, BUILD_NIXL_EP=true) has been failing in two distinct places:
Summary by CodeRabbit
New Features
Bug Fixes