Skip to content

ci: remove GitLab mirror + add nSpect/scan trigger on release/** (res… - #1806

Merged
nv-nmailhot merged 1 commit into
mainfrom
nmailhot/nixl-rc-nspect-trigger
Jun 23, 2026
Merged

nv-nmailhot merged 1 commit into
mainfrom
nmailhot/nixl-rc-nspect-trigger

Conversation

@nv-nmailhot

@nv-nmailhot nv-nmailhot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

…t of #1795)

The remaining changes from #1795, adapted to the release/** RC model:

  • Remove the GitLab bridge: build_validation.yml (repo mirror + .gitlab-ci.yml trigger) and mirror_repo.sh — superseded by the native ci.yml.
  • Add trigger-gitlab-nspect to ci.yml: on a push to a release/** branch (a PR merged into release/<x.y.z>), trigger the nixl-ci GitLab pipeline (PIPELINE_TYPE=rc) to run the wheel scan + nSpect registration (NSPECT-WO64-8O3P) against the wheels just uploaded to Artifactory. Runs on the gitlab_ci_runners group (internal reach); WHEEL_VERSION comes from the version job; NIXL_CI_REF selects the nixl-ci branch (defaults to main). (Nmailhot/nixl release pipeline #1795 gated this on v*-rc tags; re-gated for the release/** model.)

What?

Describe what this PR is doing.

Why?

Justification for the PR. If there is an existing issue/bug, please reference it. For
bug fixes, the 'Why?' and 'What?' can be merged into a single item.

How?

It is optional, but for complex PRs, please provide information about the design,
architecture, approach, etc.

Summary by CodeRabbit

  • Chores
    • Removed deprecated validation workflow and repository mirror synchronization script
    • Enhanced release pipeline with automated nSpect registration and validation for published release builds

…t of #1795)

The remaining changes from #1795, adapted to the release/** RC model:
- Remove the GitLab bridge: build_validation.yml (repo mirror + .gitlab-ci.yml
  trigger) and mirror_repo.sh — superseded by the native ci.yml.
- Add trigger-gitlab-nspect to ci.yml: on a push to a release/** branch (a PR
  merged into release/<x.y.z>), trigger the nixl-ci GitLab pipeline
  (PIPELINE_TYPE=rc) to run the wheel scan + nSpect registration
  (NSPECT-WO64-8O3P) against the wheels just uploaded to Artifactory. Runs on
  the gitlab_ci_runners group (internal reach); WHEEL_VERSION comes from the
  version job; NIXL_CI_REF selects the nixl-ci branch (defaults to main).
  (#1795 gated this on v*-rc tags; re-gated for the release/** model.)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nv-nmailhot
nv-nmailhot requested review from a team as code owners June 23, 2026 05:08
@nv-nmailhot
nv-nmailhot merged commit 6f08b8e into main Jun 23, 2026
18 of 20 checks passed
@nv-nmailhot
nv-nmailhot deleted the nmailhot/nixl-rc-nspect-trigger branch June 23, 2026 05:11
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The PR removes the build_validation.yml workflow and the mirror_repo.sh Bash script (both handling GitLab mirroring). It adds a new trigger-gitlab-nspect job in ci.yml that runs only on release/** branches, waits for wheel uploads to finish, then POSTs a GitLab pipeline trigger with nSpect registration and wheel-scan variables.

Changes

GitLab CI Infrastructure Replacement

Layer / File(s) Summary
Remove GitLab mirror script and validation workflow
.github/workflows/mirror_repo.sh, .github/workflows/build_validation.yml
Deletes the polling mirror-update Bash script and the entire build_validation workflow (mirror-to-GitLab job and GitLab CI trigger job).
Add trigger-gitlab-nspect release job
.github/workflows/ci.yml
Adds a release-branch-only job that depends on version, upload-x86-wheels, and upload-arm-wheels; securely stores the GitLab token in a temp file; POSTs a multipart trigger request with NSPECT_ID, WHEEL_VERSION, RC_TAG, ENABLE_WHEEL_SCAN, and other variables; extracts PIPELINE_ID/PIPELINE_URL via jq; errors if no pipeline ID; writes a summary table to GITHUB_STEP_SUMMARY.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • ai-dynamo/nixl#1803: Introduces or manages the version computation and wheel upload steps (upload-x86-wheels, upload-arm-wheels) in ci.yml that the new trigger-gitlab-nspect job directly depends on.

Poem

🐇 Hop hop, the mirror is gone,
No more polling from dusk until dawn.
A curl to GitLab, nSpect in sight,
Wheels get scanned in the release-branch night.
One clean trigger, the rabbit says "Right!" 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description covers what, why, and how aspects but the required template sections are not properly formatted as specified in the repository template. Restructure the description to follow the template format: clearly separate and label the What, Why, and How sections with proper markdown formatting.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: removing GitLab mirror infrastructure and adding nSpect/scan trigger on release branches.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nmailhot/nixl-rc-nspect-trigger

Comment @coderabbitai help to get the list of available commands.

dpressle pushed a commit that referenced this pull request Jun 24, 2026
#1806)

…t of #1795)

The remaining changes from #1795, adapted to the release/** RC model:
- Remove the GitLab bridge: build_validation.yml (repo mirror +
.gitlab-ci.yml trigger) and mirror_repo.sh — superseded by the native
ci.yml.
- Add trigger-gitlab-nspect to ci.yml: on a push to a release/** branch
(a PR merged into release/<x.y.z>), trigger the nixl-ci GitLab pipeline
(PIPELINE_TYPE=rc) to run the wheel scan + nSpect registration
(NSPECT-WO64-8O3P) against the wheels just uploaded to Artifactory. Runs
on the gitlab_ci_runners group (internal reach); WHEEL_VERSION comes
from the version job; NIXL_CI_REF selects the nixl-ci branch (defaults
to main). (#1795 gated this on v*-rc tags; re-gated for the release/**
model.)

## What?
_Describe what this PR is doing._

## Why?
_Justification for the PR. If there is an existing issue/bug, please
reference it. For
bug fixes, the 'Why?' and 'What?' can be merged into a single item._

## How?
_It is optional, but for complex PRs, please provide information about
the design,
architecture, approach, etc._


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
* Removed deprecated validation workflow and repository mirror
synchronization script
* Enhanced release pipeline with automated nSpect registration and
validation for published release builds

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dpressle pushed a commit that referenced this pull request Jun 24, 2026
NirWolfer pushed a commit to NirWolfer/nixl that referenced this pull request Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant