Repository navigation
feat(redis): add Redis backend with async transfers and nixlbench support #1791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aranadive
merged 76 commits into
ai-dynamo:main
from
hxieustc:pr_nixl_kv_plugin_interface_redis
Oct 4, 2026
Merged
Changes from 24 commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
02ac5ee
feat(kv): add shared KV backend interfaces under src/plugins/kv
gaowayne a190d3c
fix(kv): code style fixes
gaowayne a2eb4f7
fix(kv): document NIXL_ERR_NOT_FOUND for missing key in get()
gaowayne 75d1190
fix(kv): add local_agent to postXfer for prep/post symmetry
gaowayne a0064ba
docs(kv): add Doxygen for nixlKVEngineImpl public APIs
gaowayne 45c71dd
fix(kv): wrap getSupportedMems Doxygen comment for clang-format
gaowayne 327e9fd
feat(kv): add REDIS plugin with async SET/GET and nixlbench support
gaowayne b3643b1
refactor(kv): consolidate backend interface
hxieustc bf5dc6e
refactor(kv): hide injected impl constructor
hxieustc e3b6d2d
refactor(kv): drop local agent from postXfer
hxieustc 9233e92
docs(kv): document backend facade layout
hxieustc 025eb19
refactor(kv): move redis plugin entrypoint to kv layer
hxieustc 3ce356b
refactor(kv): make redis executor backend-specific
hxieustc 099be21
fix(kv): harden redis async transfer handling
hxieustc c997861
docs(kv): expand kv redis plugin guide
hxieustc d851589
Address Redis KV review feedback
hxieustc d97b413
Address KV review docs and Redis deps
hxieustc ce0c697
refactor(redis): simplify backend architecture
hxieustc 7c8d886
feat(redis): add client configuration and validation
hxieustc c1b6fc6
fix: clang-format and copyright year for CI checks
hxieustc 0657e6a
Fix clang-format violations in utils.cpp and redis_plugin.cpp
hxieustc c5d5ca1
feat(redis): add RedisConnectionPool with configurable pool size
hxieustc 936d97b
docs(redis): document pool_size configuration in README
hxieustc f59892b
fix(redis): remove unused size() method and add zero/negative pool_si…
hxieustc 9564c20
fix(redis): advertise RedisConfig defaults in plugin options
gaowayne 7b46412
fix(nixlbench): use OBJ_SEG for REDIS remote descriptors
gaowayne 1d5d53c
fix(nixlbench): drop hiredis from bench and address REDIS review nits
gaowayne 91de82f
Merge branch 'main' into pr_nixl_kv_plugin_interface_redis
aranadive 46aeda3
Merge branch 'main' into pr_nixl_kv_plugin_interface_redis
aranadive 5aada14
Merge branch 'main' into pr_nixl_kv_plugin_interface_redis
aranadive e593376
redis: wait for in-flight ops before releasing a transfer handle
gaowayne ce72178
redis: fix libevent_pthreads dependency check, require hiredis>=1.0.0…
hxieustc ae34e67
minor update to README.md
hxieustc 7f46d20
redis: latch terminal transfer status by clearing futures after drain
hxieustc 94be849
redis: replace dynamic_cast on metadataP with static_cast to match ot…
hxieustc 5fda1cb
redis tests: fold duplicate pool_size tests, cover trailing-garbage i…
hxieustc da58bdc
redis: replace round-robin sharder with least-loaded health-aware con…
hxieustc cbdb905
redis: consolidate N event loops into one shared event loop across al…
hxieustc 51106ff
redis: replace per-slot sync connections with one shared sync connection
hxieustc a74b45f
redis connection pool optimization: offload GET reply memcpy to worke…
hxieustc 7a393d8
fix db parsing to match port/pool_size consistency; add REDIS_DB env …
hxieustc f7efc47
remove redundant descriptor count re-check in postXfer
hxieustc 4267c28
redis: add RedisConnectionPool unit tests for construction, PUT/GET r…
hxieustc 3a61d36
redis: assert getAddrs/getLens in PollsReadUntilClientCompletes, matc…
hxieustc 1d89979
redis: read REDIS_HOST/REDIS_PORT env vars in pool tests instead of h…
hxieustc 243ef84
build: install Redis deps in contrib Dockerfiles
gaowayne cfc23ff
Merge branch 'main' into pr_nixl_kv_plugin_interface_redis
aranadive 9e7f8a3
redis: fix copyright year to 2026 in new plugin files
hxieustc 06247e2
redis: apply clang-format to redis_client.h and redis_client.cpp
hxieustc 8dec2f9
redis: apply clang-format to redis.cpp unit test
hxieustc 0f11cc6
redis: apply clang-format-19 to redis.cpp unit test
hxieustc b9f32eb
Merge branch 'main' into pr_nixl_kv_plugin_interface_redis
aranadive a7353b5
redis: fix use-after-free in connect/disconnect callbacks, and minor …
hxieustc 083fe68
redis: fix per-device key collision in fallback key resolution
hxieustc f3d30e1
hiredis for Dockerfile.manylinux has vulnerabilities, switch to build…
hxieustc 0226a44
fix bugs in deregisterMem, getCallback and checkKeyExistsSync
hxieustc d606f18
redis: drop devIdToRedisKey_ for named buffers; use hi_free for stole…
hxieustc c0c9820
redis: guard addrToRedisKey_ with shared_mutex to fix postXfer vs reg…
hxieustc d1fafd9
redis: fix double-free in authCallback/selectCallback when connection…
hxieustc 98a9ccc
redis: reject OBJ_SEG registerMem with empty metaInfo to prevent addr…
hxieustc 1820124
redis: reconnect syncCtx_ on error in checkKeyExistsSync instead of s…
hxieustc 2867ba6
redis: queryMem rejects unnamed OBJ_SEG descriptors (same rule as reg…
hxieustc 97d09a4
redis: remove dead #else stub (HAVE_HIREDIS_ASYNC is always defined f…
hxieustc 935ec68
redis tests: fix engine tests to match new key-resolution semantics (…
hxieustc fa2d02e
test_plugin: add REDIS to the known-plugin set
hxieustc 4451fd7
Dockerfile: remove leftover NIXL_ENABLE_PLUGINS/NIXL_STATIC_PLUGINS A…
hxieustc cb7f0be
redis: fix postXfer key-resolution dead branch; update README key fal…
hxieustc 5e6b34f
redis: remove devId from nixlRedisMetadata, simplify registerMem/dere…
hxieustc 0bd9862
redis: fix stopEventLoop race, add exception safety, tighten timeouts…
hxieustc bb331cd
redis tests: fix isTcpPortOpen, add DRAM_SEG key-resolution and dereg…
hxieustc fdc68de
redis: clang-format-19
hxieustc c89b4c7
Merge branch 'main' into pr_nixl_kv_plugin_interface_redis
aranadive c741843
redis: drop unversioned hiredis fallbacks in meson; validate addr in …
hxieustc f8cd17a
redis: replace bespoke config parsers with nixl::getBackendParamOptio…
hxieustc fe640dd
Merge branch 'main' into pr_nixl_kv_plugin_interface_redis
aranadive 2a18b64
Merge branch 'main' into pr_nixl_kv_plugin_interface_redis
vvenkates27 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.