-
Notifications
You must be signed in to change notification settings - Fork 192
clang-format: Add .clang-format #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e7af6a6 to
2feed42
Compare
|
/ok to test 2feed42 |
538ea02 to
fc92ca0
Compare
|
/ok to test fc92ca0 |
Add and apply .clang-format to all *.cpp and *.h files. Signed-off-by: Eylon Toledano <[email protected]>
|
/ok to test bcdac8b |
|
@etoledano I think my plan for merging this is going to be right after 0.2.0. The merge conflicts are going to be quite difficult, but once we get everything merged for 0.2.0 on Friday there should be a nice downtime where we aren't merging anything new where we can apply all these changes. @aranadive suggested we also shrink this down to a smaller PR to start with, almost like a proof of concept we can manually review to ensure everyone approves of the style, then expand back to cover everything. |
I am not in any rush, just sent a mail to initiate a discussion to hopefully push it by mid May. |
Lets add the clang format file in a separate commit and update README with clang format instructions. That way, anyone can take the file and apply it to see what works. If someone wants to update clang file based on output, we should do that before applying to all source files. |
Done in a new PR (from a fork) but it should fail since once the clang-format is updated its already applied, so it expects it to pass. The contribution guidelines already covers |
Add and apply .clang-format to all *.cpp and *.h files.
This PR replaces this one, from a branch rather than a fork.