Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions .github/workflows/rocm-build-check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
# SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

# TODO: replace this compile-only host CI with end-to-end transfer validation
# on a self-hosted MI300X/MI355X runner once available.

name: rocm-build-check

on:
pull_request:
paths:
- 'src/**'
- 'benchmark/nixlbench/**'
- 'contrib/Dockerfile'
- 'contrib/build-container.sh'
- 'contrib/build-wheel.sh'
- 'meson.build'
- 'meson_options.txt'
- '.github/workflows/rocm-build-check.yml'
workflow_dispatch:

jobs:
build:
name: ROCm container build + smoke
runs-on: ubuntu-latest
# Non-blocking for now: a from-scratch ROCm build exceeds the hosted-runner
# budget (the "-complete" image plus building UCX/gRPC/etc. from source runs
# well past the timeout). Flip to blocking once the build consumes the

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we fix the timeout issue instead?

# pre-built ghcr.io/ai-dynamo/nixl-rocm base image so only nixl is compiled.
continue-on-error: true
if: ${{ github.event_name != 'pull_request' || !github.event.pull_request.draft }}
timeout-minutes: 90
steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
with:
fetch-depth: 0
persist-credentials: false

# The ROCm "-complete" base image is ~30GB extracted and does not fit on a
# stock ubuntu-latest runner (~14GB free); reclaim space before building.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should fix the runner to use bigger disk?

- name: Free up disk space
run: |
sudo rm -rf /usr/share/dotnet /opt/ghc \
/usr/local/lib/android /opt/hostedtoolcache \
/usr/local/share/boost /usr/local/.ghcup
sudo docker image prune -af || true
sudo docker builder prune -af || true
df -h /

# docker-container driver is required for --output=type=cacheonly below.
- name: Set up buildx (docker-container driver)
run: docker buildx create --use --driver docker-container --name nixl-ci

# Build the full ROCm graph without exporting an image. The wheel-presence
# and `import nixl` -> nixl_rocm smoke checks run as RUN steps inside the
# rocm-build stage, so --output=cacheonly validates them without the
# multi-GB image export that OOMs the hosted runner during compression.
- name: Build ROCm container (validate, no image export)
run: ./contrib/build-container.sh --rocm --check-only --no-cache
57 changes: 57 additions & 0 deletions .github/workflows/wheel-rocm.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
# SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

# Builds the nixl_rocm wheel on tagged releases and uploads it as a release asset.

name: wheel-rocm

on:
push:
tags:
- 'v*'
workflow_dispatch:
inputs:
ref:
description: 'Git ref to build'
required: false
type: string
Comment thread
coderabbitai[bot] marked this conversation as resolved.

concurrency:
group: wheel-rocm-${{ github.ref }}
cancel-in-progress: false

jobs:
build-wheel:
name: Build nixl_rocm wheel
runs-on: ubuntu-latest
timeout-minutes: 90
steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
with:
ref: ${{ inputs.ref || github.ref }}
fetch-depth: 0
persist-credentials: false

- name: Build ROCm container
run: ./contrib/build-container.sh --rocm --tag nixl-rocm:wheel --no-cache

- name: Extract wheels
run: |
mkdir -p dist
id=$(docker create nixl-rocm:wheel)
docker cp "$id":/workspace/nixl/dist/. dist/
docker rm "$id"
ls -la dist/

- name: Upload wheel artifacts
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
with:
name: nixl-rocm-wheels
path: dist/*.whl
if-no-files-found: error

- name: Attach to release
if: startsWith(github.ref, 'refs/tags/v')
uses: softprops/action-gh-release@3bb12739c298aeb8a4eeaf626c5b8d85266b0e65 # v2
with:
files: dist/*.whl
Loading
Loading