Repository navigation
test: fix maybe-uninitialized warning in metadata_exchange test - #1473
Conversation
Initialize status = NIXL_ERR_NOT_FOUND before the backend creation loop to silence g++ -Werror=maybe-uninitialized. Signed-off-by: Ben Walker <ben@nvidia.com>
|
👋 Hi benlwalker! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA test-local variable Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2279c7d to
863e27b
Compare
|
/ok to test 4e84394 |
|
/build |
What?
Initialize status = NIXL_ERR_NOT_FOUND before the backend creation loop to silence g++ -Werror=maybe-uninitialized.
Why?
This fails to compile on new g++
How?
Initialize the variable before use.
Summary by CodeRabbit