Repository navigation
Support OS-assigned ports for metadata listener - #1439
Merged
Merged
Conversation
|
👋 Hi guy-ealey-morag! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
guy-ealey-morag
force-pushed
the
os-assigned-ports
branch
from
March 18, 2026 15:27
9c4016f to
36c8ba2
Compare
guy-ealey-morag
changed the title
guy-ealey-morag
force-pushed
the
os-assigned-ports
branch
from
March 18, 2026 15:35
36c8ba2 to
f086621
Compare
Contributor
Author
|
/build |
guy-ealey-morag
force-pushed
the
os-assigned-ports
branch
from
March 18, 2026 16:59
f086621 to
3696f57
Compare
ColinNV
previously approved these changes
Mar 30, 2026
roiedanino
reviewed
Apr 6, 2026
Signed-off-by: Guy Ealey Morag <gealeymorag@nvidia.com>
Contributor
Author
|
Refactored to read the os-assigned port through the logs instead of using an env var. |
ColinNV
reviewed
Apr 21, 2026
Signed-off-by: Guy Ealey Morag <gealeymorag@nvidia.com>
tomerg-nvidia
previously approved these changes
Apr 23, 2026
Signed-off-by: Guy Ealey Morag <gealeymorag@nvidia.com>
ColinNV
reviewed
Apr 23, 2026
Alexey-Rivkin
previously requested changes
Apr 23, 2026
Contributor
Author
|
I reverted the last change because it wasn't robust enough, I'll work on improvements for another PR. |
Signed-off-by: Guy Ealey Morag <gealeymorag@nvidia.com>
Contributor
Author
|
/build |
Contributor
Author
|
/build |
ColinNV
approved these changes
Apr 27, 2026
tomerg-nvidia
approved these changes
Apr 29, 2026
brminich
approved these changes
May 13, 2026
Contributor
|
/build |
This was referenced Oct 1, 2026
This was referenced Oct 12, 2026
Draft
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Allow NIXL agents to bind their metadata listener to an OS-assigned port (marked with
0).Update CI test scripts to use this mechanism instead of
get_next_tcp_port(), and fetch the assigned port using a file that the selected port is written to.Why?
CI tests occasionally fail with
Address already in usedue to a race condition withget_next_tcp_port(). OS-assigned ports eliminate the race entirely.