TEST/GTEST: Allow any ETCD namespace. - #1408
Conversation
|
👋 Hi ColinNV! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR generalizes log-filtering regexes in metadata exchange tests, replacing exact numeric path segments with a wildcard pattern in LogIgnoreGuard initializations; no control flow, signatures, or test assertions were changed. (49 words) Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/build |
|
/build |
|
/build |
|
/build |
|
/build |
What?
Allow the gtests to succeed with any ETCD namespace
Why?
The tests were accidentally hard-coded to the ETCD namespace used by the CI scripts.
How?
Change the regular expressions for expected log messages to be ETCD namespace independent.
Summary by CodeRabbit