Skip to content

TEST/GTEST: Allow any ETCD namespace. - #1408

Merged
brminich merged 7 commits into
ai-dynamo:mainfrom
ColinNV:gtest_namespace
Mar 16, 2026
Merged

brminich merged 7 commits into
ai-dynamo:mainfrom
ColinNV:gtest_namespace

Conversation

@ColinNV

@ColinNV ColinNV commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

What?

Allow the gtests to succeed with any ETCD namespace

Why?

The tests were accidentally hard-coded to the ETCD namespace used by the CI scripts.

How?

Change the regular expressions for expected log messages to be ETCD namespace independent.

Summary by CodeRabbit

  • Tests
    • Relaxed log-filtering patterns in unit tests to be more flexible across environments and naming variations, reducing false positives from timed-watch log messages.
    • No changes to public APIs or test control flow; adjustments are limited to how noisy log output is matched/ignored.

@github-actions

github-actions Bot commented Mar 6, 2026

Copy link
Copy Markdown

👋 Hi ColinNV! Thank you for contributing to ai-dynamo/nixl.

Your PR reviewers will review your contribution then trigger the CI to test your changes.

🚀

@pull-request-size pull-request-size Bot added size/S and removed size/XS labels Mar 6, 2026
@coderabbitai

coderabbitai Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2a704c06-9aaa-4b6f-b081-e208df41adfd

📥 Commits

Reviewing files that changed from the base of the PR and between 54a54b7 and 1477968.

📒 Files selected for processing (1)
  • test/gtest/metadata_exchange.cpp

📝 Walkthrough

Walkthrough

The PR generalizes log-filtering regexes in metadata exchange tests, replacing exact numeric path segments with a wildcard pattern in LogIgnoreGuard initializations; no control flow, signatures, or test assertions were changed. (49 words)

Changes

Cohort / File(s) Summary
Test Log Pattern Updates
test/gtest/metadata_exchange.cpp
Replaced multiple LogIgnoreGuard regex literals that matched /nixl/cpp_ci/[0-9]+/... with a generic .* wildcard (e.g., Watch timed out for key: .*/agent_0/metadata, .../invalid_agent_name/metadata, .../agent_0/invalid_label) to relax path-specific matching.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 I hopped through logs both near and far,
Numbers gave way to a single star.
Wildcards now dance where digits once stood,
Tests stay steady — the meadow's still good.
🌿

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: making GTEST tests namespace-agnostic for ETCD, which aligns perfectly with the changeset's focus on replacing hardcoded namespace patterns with generic regex patterns.
Description check ✅ Passed The description follows the template completely with all required sections (What, Why, How) filled out appropriately and providing clear context about the fix.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@brminich

brminich commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

/build

@brminich
brminich enabled auto-merge (squash) March 6, 2026 15:11
@ColinNV

ColinNV commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

/build

@ColinNV

ColinNV commented Mar 12, 2026

Copy link
Copy Markdown
Contributor Author

/build

@ColinNV

ColinNV commented Mar 14, 2026

Copy link
Copy Markdown
Contributor Author

/build

@ColinNV

ColinNV commented Mar 16, 2026

Copy link
Copy Markdown
Contributor Author

/build

@brminich
brminich merged commit 0a8c3bf into ai-dynamo:main Mar 16, 2026
16 of 17 checks passed
@ColinNV
ColinNV deleted the gtest_namespace branch March 16, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants