nixl_worker: file_offset calculation fixed

[anton-nayshtut]

What?

Fix file_offset calculation for non-GUSLI plugins.

Why?

The regression was introduced by commit 62a5b3e.

How?

file_offset calculation differs between GUSLI and POSIX plugins, so I wrapped the GUSLI-specific fix introduced by 62a5b3e in the appropriate if.

Summary by CodeRabbit

• Bug Fixes
  • Corrected file offset advancement behavior for storage backends to ensure proper data placement and consistent state management across backend types.

[github-actions]

👋 Hi anton-nayshtut! Thank you for contributing to ai-dynamo/nixl.

Your PR reviewers will review your contribution then trigger the CI to test your changes.

🚀

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8d41f975-2fe7-4189-b874-6dd35cd12854

📥 Commits

Reviewing files that changed from the base of the PR and between d030c96 and dfa981b.

📒 Files selected for processing (1)

• benchmark/nixlbench/src/worker/nixl/nixl_worker.cpp

---

📝 Walkthrough

Walkthrough

Modified the exchangeIOV function in the storage backend worker to make file offset advancement conditional on backend type. The file_offset now only advances by block_size when the GUSLI backend is used, whereas previously it advanced for all backends after each iov_list operation.

Changes

Cohort / File(s)	Summary
Storage Backend I/O Logic benchmark/nixlbench/src/worker/nixl/nixl_worker.cpp	Modified exchangeIOV to conditionally advance file_offset only for GUSLI backend, altering state progression for OBJ and FILE backends.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~18 minutes

Poem

🐰 A rabbit hops through offset rows,
Where GUSLI blocks now gently flows,
While OBJ and FILE stay their ground,
Each backend's path distinctly found! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: fixing file_offset calculation in nixl_worker, which matches the core objective of the PR.
Description check	✅ Passed	The description includes all required sections (What, Why, How) with relevant details about the fix, regression reference, and implementation approach.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[anton-nayshtut]

/build