Repository navigation
Do not fail silently on metadata listener socket setup - #1371
Merged
Merged
Conversation
Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
|
👋 Hi ovidiusm! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
Contributor
Author
|
/build |
Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
Contributor
Author
|
/build |
rakhmets
reviewed
Feb 26, 2026
Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
Contributor
Author
|
/build |
rakhmets
approved these changes
Feb 26, 2026
brminich
approved these changes
Feb 27, 2026
staryxchen
pushed a commit
to staryxchen/nixl
that referenced
this pull request
Mar 7, 2026
--------- Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
Merged
This was referenced Oct 12, 2026
Draft
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fail hard on metadata socket creation failure
Why?
Currently the code logs a warning when socket bind fails, but then continues with an invalid socket. This results in a lot of:
Instead, we should throw an exception and fail agent creation in the constructor if cfg.useListenThread == true
Sample log from current failure case: