Skip to content

Pin Python CUDA-specific deps to exact version - #1354

Merged
ovidiusm merged 2 commits into
ai-dynamo:mainfrom
ovidiusm:fix-python-metadata
Feb 25, 2026
Merged

ovidiusm merged 2 commits into
ai-dynamo:mainfrom
ovidiusm:fix-python-metadata

Conversation

@ovidiusm

@ovidiusm ovidiusm commented Feb 24, 2026 •

Copy link
Copy Markdown
Contributor

What?

Python meta wheels must pull same version CUDA-specific wheels

Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
@github-actions

Copy link
Copy Markdown

👋 Hi ovidiusm! Thank you for contributing to ai-dynamo/nixl.

Your PR reviewers will review your contribution then trigger the CI to test your changes.

🚀

@coderabbitai

coderabbitai Bot commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c7e97a4 and 66b6cd7.

📒 Files selected for processing (1)
  • src/bindings/python/nixl-meta/pyproject.toml.in

📝 Walkthrough

Walkthrough

The pull request modifies the Python package configuration to enforce exact version pinning for two optional CUDA dependencies (cu12 and cu13), changing their version specifiers from minimum constraints (>=) to exact constraints (==).

Changes

Cohort / File(s) Summary
Dependency Version Pinning
src/bindings/python/nixl-meta/pyproject.toml.in
Updated optional dependencies cu12 and cu13 to use exact version constraints (==@VERSION@) instead of minimum constraints (>=@VERSION@).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐰 Hop, hop, the versions align,
No more "or greater," now it's mine!
Exact pins secure the CUDA way,
Dependencies locked in, hip hooray! 🎉

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is missing required sections. Only 'What?' is partially filled; 'Why?' and 'How?' sections are completely absent from the description. Add 'Why?' section explaining the reason for pinning to exact versions (e.g., compatibility requirements) and optionally a 'How?' section if the implementation is complex.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: pinning Python CUDA-specific dependencies to exact versions instead of minimum versions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ovidiusm

Copy link
Copy Markdown
Contributor Author

/build

@ovidiusm

Copy link
Copy Markdown
Contributor Author

/build

@brminich

Copy link
Copy Markdown
Contributor

/build

@ovidiusm

Copy link
Copy Markdown
Contributor Author

/build

@ovidiusm
ovidiusm enabled auto-merge (squash) February 25, 2026 14:19
@ovidiusm
ovidiusm merged commit 01d19b6 into ai-dynamo:main Feb 25, 2026
18 of 19 checks passed
@ovidiusm
ovidiusm deleted the fix-python-metadata branch February 25, 2026 14:41
isdrk pushed a commit to isdrk/nixl that referenced this pull request Feb 25, 2026
Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
nv-nmailhot pushed a commit that referenced this pull request Feb 27, 2026
Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
nv-nmailhot pushed a commit that referenced this pull request Feb 27, 2026
Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>

This branch was previously deployed

2 inactive deployments
GITLAB — eaa539e0 Deployed Feb 25, 2026 by copy-pr-bot[bot] via Trigger CI Pipeline #7137
SWX_AWS — eaa539e0 Deployed Feb 25, 2026 by copy-pr-bot[bot] via Run AWS Tests - Python Tests #5822
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants