Conversation
Lets use S3 CRT Client as an additional client type when creating the object plugin. The CRT Client generally performs better for large objects by supporting multi-parting automatically and ranged GETs. This increases throughput and will help large KV transfers to objects. Both the S3Client and S3CRTClient are used based on a new backend parameter called crtMinLimit. This determines the client type used of the object size to be transfered is larger than this value, then the S3CRTClient is used. Since S3 and S3CRT are very similar API wise, most of the common code is refactored into separate files. Also, Dockerfiles are modified to compile the s3crt client as well. Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
By default the tests use small object sizes, I modified the transfer handler to create larger objects based on parameters passed. The CRT tests will use these when testing. Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
Move the common utilities for S3 and S3CRT to the utils folder. Other S3-based object plugins can link to the utils lib as required. Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
Some more reorg of the object plugin to let each object storage api have its own directory. Should make it easier to onboard other S3-type plugins. Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
obj): Implement hierarchical object storage client architecture
Introduce a modular, inheritance-based architecture for object storage
clients to support multiple S3-compatible backends and acceleration paths.
Architecture Overview:
iObjClient (base interface)
└── awsS3Client (S3 Vanilla)
├── awsS3CrtClient (S3 CRT for large objects)
└── awsS3AccelClient (S3 Accelerated)
└── awsDellOBSClient (Dell ObjectScale)
Key Changes:
- Create base/client.h with iObjClient interface defining common operations
(setExecutor, putObjectAsync, getObjectAsync, checkObjectExists)
- Reorganize S3 clients into subdirectories:
* s3/ - Standard S3 client (awsS3Client) inheriting from iObjClient
* s3_crt/ - S3 CRT client (awsS3CrtClient) inheriting from awsS3Client
* s3_accel/ - S3 Accelerated client using CRT implementation
* s3_accel/dell_obs/ - Dell OBS client with vendor-specific optimizations
- Update obj_backend to dynamically instantiate clients based on parameters:
* Default: S3 Vanilla client
* accelerated=true: S3 Accel client
* accelerated=true,type=dell: Dell OBS client
* S3 CRT client now optional (only when crtMinLimit is configured)
- Refactor client member types to use polymorphic iObjClient interface
for simplified transfer logic and extensibility
Benefits:
- Clean separation of concerns with distinct client types
- Easy addition of new vendor-specific backends
- Flexible runtime client selection via custom parameters
- Maintains backward compatibility with existing configurations"
Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
|
👋 Hi aranadive! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Introduce a modular, inheritance-based architecture for object storage
clients to support multiple S3-compatible backends and acceleration paths.
The new hierarchy organizes clients as follows:
Why?
The previous flat architecture made it difficult to extend the object plugin
with new vendor-specific backends and acceleration methods. This refactoring
provides:
How?
Created base/client.h with iObjClient interface defining common operations
(setExecutor, putObjectAsync, getObjectAsync, checkObjectExists)
Reorganized S3 clients into subdirectories reflecting inheritance:
Updated obj_backend to dynamically instantiate clients based on parameters:
Refactored client member types to use polymorphic iObjClient interface