Repository navigation
feat: Pluggable Pool Discovery for the Global Router - #103
Closed
atchernych wants to merge 19 commits into
Closed
atchernych wants to merge 19 commits into
atchernych wants to merge 19 commits into
Conversation
Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
atchernych
marked this pull request as draft
September 26, 2026 22:28
atchernych
changed the title
Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
The file stays local for further work. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
atchernych
changed the title
Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
atchernych
added a commit
to ai-dynamo/dynamo
that referenced
this pull request
Oct 11, 2026
Addresses the CodeRabbit review: internal Linear IDs do not resolve for external readers. No GitHub issue tracks this work, so link the public design proposal (ai-dynamo/enhancements#103) instead. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
Pool discovery now runs in a Global Discovery Service that serves every option over HTTP (POST /pools, GET /pools, GET /routers), so pools live in the service rather than the router, PoolRelays find router replicas with GET /routers in every mode, and no gRPC announcer exists. The relay check belongs to the router, and the Full Kubernetes option also takes registrations, for what MCS cannot know. Hybrid is marked as not built. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
The discovery service now lists `relay_identities`, one per address of the PoolRelay's pod, so a dual-stack PoolRelay matches from either family. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
…nobs - Explain the two knobs: --pool-discovery (registrations, karmada, mcs) says where the pool list comes from, and --registration-storage (memory now, Kubernetes or DynamoDB later) says where registrations are kept. - Describe the Global Discovery Service's HTTP API and map the three options onto the knobs: Registrations (was gRPC Native), Hybrid (not built) and MCS (was Full Kubernetes). - Match the code in ai-dynamo/dynamo #17330, #17208, #17331, #17371, #17332, #17333 and #17412: registrations joined with MCS, router replicas from GET /routers, operator ServiceExports for the PoolRelay and frontend Services, and Karmada's 55-character name limit. - Move registering with each router replica to Alternate Solutions, update the open questions, and drop a router name that is internal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
The DEP is now filed as an issue on ai-dynamo/dynamo, where DEPs live. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
Author
|
This DEP now lives in ai-dynamo/dynamo#17600, since DEPs are now filed as issues on the dynamo repo. The text there matches this PR's file. Closing this PR so there is one copy to review; the review comments here stay for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.