Skip to content

fix: kvbm breaking change - Updated kv_cache_connector lib import to reflect the updates made to trtllm 1.3.0rc14 - #9622

Merged
nv-kmcgill53 merged 2 commits into
mainfrom
kmcgill/fix-kvbm-trtllm-import
May 18, 2026
Merged

fix: kvbm breaking change - Updated kv_cache_connector lib import to reflect the updates made to trtllm 1.3.0rc14#9622
nv-kmcgill53 merged 2 commits into
mainfrom
kmcgill/fix-kvbm-trtllm-import

Conversation

@nv-kmcgill53

@nv-kmcgill53 nv-kmcgill53 commented May 15, 2026

Copy link
Copy Markdown
Contributor

Overview:

TensorRT-LLM made a breaking change in how they organized the kv cache connectors in their project, see here. This PR makes a corresponding breaking change in kvbm to work with TRTLLM 1.3.0rc14 or later. Compatibility with earlier versions of TRTLLM will be dropped with this change.

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

Summary by CodeRabbit

  • Chores
    • Updated internal import paths for KV cache connector modules to reflect module reorganization.

Review Change Stack

@nv-kmcgill53 nv-kmcgill53 self-assigned this May 15, 2026
@nv-kmcgill53
nv-kmcgill53 requested review from a team as code owners May 15, 2026 18:12
@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Two TensorRT-LLM connector integration modules update their import statements to use the reorganized tensorrt_llm._torch.pyexecutor.connectors.kv_cache_connector module path instead of the prior flat module structure. No logic or behavior changes.

Changes

KV Cache Connector Import Refactoring

Layer / File(s) Summary
KV cache connector import path migration
lib/bindings/kvbm/python/kvbm/trtllm_integration/connector/kvbm_connector_leader.py, lib/bindings/kvbm/python/kvbm/trtllm_integration/connector/kvbm_connector_worker.py
Connector modules redirect their imports for KvCacheConnectorScheduler, SchedulerOutput, and KvCacheConnectorWorker from the flat tensorrt_llm._torch.pyexecutor.kv_cache_connector module to the reorganized tensorrt_llm._torch.pyexecutor.connectors.kv_cache_connector path.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description provides an overview and context but is missing critical sections required by the template. Complete the 'Details' and 'Where should the reviewer start?' sections with specific information about the import path changes and file locations to review.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and specifically summarizes the main change: updating kvbm's kv_cache_connector import to reflect TensorRT-LLM 1.3.0rc14 changes, matching the file modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@lib/bindings/kvbm/python/kvbm/trtllm_integration/connector/kvbm_connector_leader.py`:
- Around line 15-18: The project dependency for tensorrt-llm must be bumped to
match the import used in kvbm_connector_leader.py: update the pyproject.toml
requirement from tensorrt-llm==1.3.0rc11 to tensorrt-llm==1.3.0rc14 so the
module path tensorrt_llm._torch.pyexecutor.connectors.kv_cache_connector and
symbols KvCacheConnectorScheduler and SchedulerOutput can be imported at
runtime; modify the version constraint in pyproject.toml accordingly and run
dependency resolution/tests to ensure the new package is installed.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8d6f6e79-d203-4ea9-a4fc-448f65243110

📥 Commits

Reviewing files that changed from the base of the PR and between 1b1c2c9 and 1e0006e.

📒 Files selected for processing (2)
  • lib/bindings/kvbm/python/kvbm/trtllm_integration/connector/kvbm_connector_leader.py
  • lib/bindings/kvbm/python/kvbm/trtllm_integration/connector/kvbm_connector_worker.py

@copy-pr-bot

copy-pr-bot Bot commented May 15, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@nv-kmcgill53 nv-kmcgill53 changed the title Fix: kvbm breaking change - Updated kv_cache_connector lib import to reflect the updates made to trtllm 1.3.0rc14 fix: kvbm breaking change - Updated kv_cache_connector lib import to reflect the updates made to trtllm 1.3.0rc14 May 15, 2026
@nv-kmcgill53

Copy link
Copy Markdown
Contributor Author

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented May 15, 2026

Copy link
Copy Markdown

/ok to test

@nv-kmcgill53, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@nv-kmcgill53

Copy link
Copy Markdown
Contributor Author

/ok to test

@dynamo-ops dynamo-ops left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous review comments have been addressed. Approving.

@nv-kmcgill53
nv-kmcgill53 merged commit 8fbd862 into main May 18, 2026
95 checks passed
@nv-kmcgill53
nv-kmcgill53 deleted the kmcgill/fix-kvbm-trtllm-import branch May 18, 2026 15:59
nv-kmcgill53 added a commit that referenced this pull request May 18, 2026
…reflect the updates made to trtllm 1.3.0rc14 (#9622)
saturley-hall pushed a commit that referenced this pull request May 20, 2026
…reflect the updates made to trtllm 1.3.0rc14 (#9622) (#9690)

Co-authored-by: Krishnan Prashanth <140860868+KrishnanPrash@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants