fix: kvbm breaking change - Updated kv_cache_connector lib import to reflect the updates made to trtllm 1.3.0rc14 - #9622
Conversation
…t the updates made to trtllm 1.3.0rc14
WalkthroughTwo TensorRT-LLM connector integration modules update their import statements to use the reorganized ChangesKV Cache Connector Import Refactoring
🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@lib/bindings/kvbm/python/kvbm/trtllm_integration/connector/kvbm_connector_leader.py`:
- Around line 15-18: The project dependency for tensorrt-llm must be bumped to
match the import used in kvbm_connector_leader.py: update the pyproject.toml
requirement from tensorrt-llm==1.3.0rc11 to tensorrt-llm==1.3.0rc14 so the
module path tensorrt_llm._torch.pyexecutor.connectors.kv_cache_connector and
symbols KvCacheConnectorScheduler and SchedulerOutput can be imported at
runtime; modify the version constraint in pyproject.toml accordingly and run
dependency resolution/tests to ensure the new package is installed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8d6f6e79-d203-4ea9-a4fc-448f65243110
📒 Files selected for processing (2)
lib/bindings/kvbm/python/kvbm/trtllm_integration/connector/kvbm_connector_leader.pylib/bindings/kvbm/python/kvbm/trtllm_integration/connector/kvbm_connector_worker.py
|
/ok to test |
@nv-kmcgill53, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
3743713 to
13650d7
Compare
|
/ok to test |
dynamo-ops
left a comment
There was a problem hiding this comment.
Previous review comments have been addressed. Approving.
…reflect the updates made to trtllm 1.3.0rc14 (#9622)
Overview:
TensorRT-LLM made a breaking change in how they organized the kv cache connectors in their project, see here. This PR makes a corresponding breaking change in kvbm to work with TRTLLM 1.3.0rc14 or later. Compatibility with earlier versions of TRTLLM will be dropped with this change.
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit