fix(preprocessor): drop dead choice.stop_reason assignment - #9403
fix(preprocessor): drop dead choice.stop_reason assignment#9403krishung5 wants to merge 1 commit into
Conversation
#8119 removed `stop_reason` from `ChatChoiceStream` after #9058 had already added an assignment to that field in the eof-flushed-buffers fallback path. The next commit on main (#9230) only touched sglang Dockerfile/templates, so path-filtered CI skipped rust-clippy, and the broken combination landed silently. Any downstream PR that triggers a fresh build hits: error[E0609]: no field `stop_reason` on type `&mut dynamo_protocols::types::ChatChoiceStream` --> lib/llm/src/preprocessor.rs:1581 The struct's per-field reset is otherwise complete; removing the orphaned line is enough to restore main's compile. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough
ChangesStream Delta Field Cleanup
🎯 1 (Trivial) | ⏱️ ~3 minutes Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Main HEAD currently fails to compile:
```
error[E0609]: no field `stop_reason` on type `&mut dynamo_protocols::types::ChatChoiceStream`
--> lib/llm/src/preprocessor.rs:1581
1581 | choice.stop_reason = None;
| ^^^^^^^^^^^ unknown field
= note: available fields are: `index`, `delta`, `finish_reason`, `logprobs`
```
Cause: two PRs landed today in a way that left the tree internally inconsistent —
The next commit on main (#9230 `8cee1e50e1`, "sglang 0.5.11 bump") only touched sglang/Dockerfile files, so the Pre Merge workflow's path filter skipped `rust-clippy`/`rust-tests` entirely. The broken combination landed silently and is now exposed on every downstream PR that triggers a fresh build (e.g. #9352).
Fix
Drop the orphaned assignment. The surrounding code already resets every remaining field on the struct.
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit