Skip to content

test: stabilize nightly — skip engine-init failures, convert xfails to skips, fix http URL validation regression #8443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmitry-tokarev-nv merged 10 commits into from
Apr 21, 2026
Merged

test: stabilize nightly — skip engine-init failures, convert xfails to skips, fix http URL validation regression #8443

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
712761e
test(fault_tolerance): skip vllm prefill_cancel test pending engine fix
dmitry-tokarev-nv Apr 21, 2026
32ce9e9
test(serve): skip qwen3-vl-2b e_pd/epd vLLM multimodal profiles
dmitry-tokarev-nv Apr 21, 2026
e4e8996
test(serve): link qwen3-vl-2b disagg skips to OPS-4445
dmitry-tokarev-nv Apr 21, 2026
c1cc2fa
test(fault_tolerance): convert vllm migration xfails to skips
dmitry-tokarev-nv Apr 21, 2026
d634588
test(serve): allow http URLs in multimodal_agg_llava + aggregated_too…
dmitry-tokarev-nv Apr 21, 2026
c145464
Apply suggestion from @dmitry-tokarev-nv
dmitry-tokarev-nv Apr 21, 2026
b3ac5ce
test(fault_tolerance): extend sglang migration skip to TCP transport …
dmitry-tokarev-nv Apr 21, 2026
2dabd67
test(trtllm): skip nightly failures, convert cancellation xfails to s…
dmitry-tokarev-nv Apr 21, 2026
8084d1b
test(trtllm): link skipped nightly failures to OPS-4450
dmitry-tokarev-nv Apr 21, 2026
02d348a
formatting
dmitry-tokarev-nv Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/fault_tolerance/cancellation/test_vllm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,7 @@ def test_request_cancellation_vllm_decode_cancel(
)


@pytest.mark.skip(reason="Nightly CI failure: TODO(<LINEAR-ID>)")
Comment thread
dmitry-tokarev-nv marked this conversation as resolved.
Resolved
Comment thread
dmitry-tokarev-nv marked this conversation as resolved.
Resolved
@pytest.mark.timeout(150) # 3x average
@pytest.mark.nightly
@pytest.mark.gpu_2
Expand Down
8 changes: 3 additions & 5 deletions tests/fault_tolerance/migration/test_vllm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ def test_request_migration_vllm_aggregated(
)


@pytest.mark.xfail(strict=False, reason="Prefill migration not yet supported")
@pytest.mark.skip(reason="Prefill migration not yet supported")
@pytest.mark.timeout(350) # 3x average
@pytest.mark.nightly
def test_request_migration_vllm_prefill(
Expand Down Expand Up @@ -346,8 +346,7 @@ def test_request_migration_vllm_prefill(
)


@pytest.mark.xfail(
strict=False,
@pytest.mark.skip(
reason=(
"Migration reuses the same request_id for vLLM, but the prefill worker's "
"KV cache still holds the request due to delay_free_blocks in disaggregated mode. "
Expand Down Expand Up @@ -430,8 +429,7 @@ def test_request_migration_vllm_kv_transfer(
)


@pytest.mark.xfail(
strict=False,
@pytest.mark.skip(
reason=(
"Migration reuses the same request_id for vLLM, but the prefill worker's "
"KV cache still holds the request due to delay_free_blocks in disaggregated mode. "
Expand Down
24 changes: 21 additions & 3 deletions tests/serve/multimodal_profiles/vllm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,24 @@
profiled_vram_gib=9.6,
),
"e_pd": TopologyConfig(
marks=[pytest.mark.pre_merge],
marks=[
pytest.mark.skip(
reason="vLLM engine core init fails on disagg e_pd. "
"https://linear.app/nvidia/issue/OPS-4445"
),
pytest.mark.pre_merge,
],
timeout_s=340,
single_gpu=True,
),
"epd": TopologyConfig(
marks=[pytest.mark.pre_merge],
marks=[
pytest.mark.skip(
reason="vLLM engine core init fails on disagg epd. "
"https://linear.app/nvidia/issue/OPS-4445"
),
pytest.mark.pre_merge,
],
timeout_s=300,
single_gpu=True,
),
Expand All @@ -56,7 +68,13 @@
delayed_start=60,
),
"epd": TopologyConfig(
marks=[pytest.mark.pre_merge],
marks=[
pytest.mark.skip(
reason="vLLM engine core init fails on disagg epd. "
"https://linear.app/nvidia/issue/OPS-4445"
),
pytest.mark.pre_merge,
],
timeout_s=600,
delayed_start=60,
single_gpu=True,
Expand Down
2 changes: 2 additions & 0 deletions tests/serve/test_vllm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,7 @@ class VLLMConfig(EngineConfig):
],
model="llava-hf/llava-1.5-7b-hf",
script_args=["--model", "llava-hf/llava-1.5-7b-hf"],
env={"DYN_MM_ALLOW_INTERNAL": "1"},
delayed_start=0,
timeout=360,
request_payloads=[
Expand Down Expand Up @@ -471,6 +472,7 @@ class VLLMConfig(EngineConfig):
"--dyn-tool-call-parser",
"hermes",
],
env={"DYN_MM_ALLOW_INTERNAL": "1"},
delayed_start=0,
timeout=600,
request_payloads=[
Expand Down
Loading