Skip to content

fix(logging): remove duplicate request_id field in request lifecycle logs #8307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sengopal wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(logging): remove duplicate request_id field in request lifecycle logs #8307

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2af9c9a
fix(runtime): downgrade per-request lifecycle logs from info to debug
sengopal Apr 17, 2026
1b4218b
fix(runtime): remove duplicate request_id from lifecycle log fields
sengopal Apr 17, 2026
aad4fcc
fix(runtime): restore if-let pattern for request_id guard
sengopal Apr 17, 2026
8949acf
Merge branch 'main' into fix/push-handler-request-log-level
sengopal Apr 17, 2026
2cf649e
Merge branch 'main' into fix/push-handler-request-log-level
sengopal Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/runtime/src/pipeline/network/ingress/push_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ impl Drop for RequestMetricsGuard {
self.inflight_requests.dec();
self.request_duration
.observe(self.start_time.elapsed().as_secs_f64());
if let Some(request_id) = &self.request_id {
tracing::info!(request_id = %request_id, "request completed");
if let Some(_) = &self.request_id {
tracing::info!("request completed");

@devin-ai-integration devin-ai-integration Bot Apr 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Log level accidentally reverted from debug to info in Drop impl

The immediately preceding commit (2af9c9aa6e) deliberately downgraded these per-request lifecycle logs from info to debug (commit message: "fix(runtime): downgrade per-request lifecycle logs from info to debug"). This commit, which only intends to remove the duplicate request_id field, accidentally changes tracing::debug! back to tracing::info!. In production with high request volume, this will cause excessive logging at the info level — exactly the problem the previous commit fixed.

Suggested change
tracing::info!("request completed");
tracing::debug!("request completed");
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

}
}
}
Expand Down Expand Up @@ -178,8 +178,8 @@ where
m.request_counter.inc();
m.inflight_requests.inc();
m.request_bytes.inc_by(payload.len() as u64);
if let Some(rid) = &request_id {
tracing::info!(request_id = %rid, "request received");
if let Some(_) = &request_id {
tracing::info!("request received");

@devin-ai-integration devin-ai-integration Bot Apr 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Log level accidentally reverted from debug to info in handle_payload

Same issue as in the Drop impl: the previous commit (2af9c9aa6e) deliberately downgraded this log from info to debug, and this commit accidentally reverts it back to info while removing the request_id field. This will produce a noisy info-level "request received" log for every incoming request.

Suggested change
tracing::info!("request received");
tracing::debug!("request received");
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

}
RequestMetricsGuard {
inflight_requests: m.inflight_requests.clone(),
Expand Down
Loading