Skip to content

chore: Update AWS SDK version used - #6841

Merged
aranadive merged 1 commit into
ai-dynamo:mainfrom
aranadive:update_s3_sdk
Mar 4, 2026
Merged

aranadive merged 1 commit into
ai-dynamo:mainfrom
aranadive:update_s3_sdk

Conversation

@aranadive

@aranadive aranadive commented Mar 3, 2026 •

Copy link
Copy Markdown
Contributor

NIXL is moving to the latest SDK as there is a use-after-free bug in the S3 CRT SDK. Lets move Dynamo components too.

See: ai-dynamo/nixl#1387

Summary by CodeRabbit

  • Chores
    • Updated AWS SDK dependency to the latest compatible version, improving library compatibility and stability.

NIXL is moving to the latest SDK as there is a use-after-free bug in the
S3 CRT SDK. Lets move Dynamo components too.

Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
@aranadive
aranadive requested review from a team March 3, 2026 23:20
@aranadive
aranadive requested review from a team as code owners March 3, 2026 23:20
@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

👋 Hi aranadive! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions Bot added external-contribution Pull request is from an external contributor chore container labels Mar 3, 2026
@coderabbitai

coderabbitai Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 62ec9f5 and 4ef3bc4.

📒 Files selected for processing (1)
  • container/templates/wheel_builder.Dockerfile

Walkthrough

Updated the AWS SDK for C++ version in the vllm build configuration from 1.11.581 to 1.11.760. This is a single-line version increment within the conditional vllm framework block of the wheel builder Dockerfile.

Changes

Cohort / File(s) Summary
AWS SDK Dependency Version Update
container/templates/wheel_builder.Dockerfile
Version bump for ARG AWS_SDK_CPP_VERSION from 1.11.581 to 1.11.760 in the vllm framework build path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A version hops higher, from 581 to 760 so bright,
The AWS SDK climbs skyward with all its might,
For vllm's swift building, this update shall do,
A small change, but steady—much versioning ado! 🚀

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description explains the rationale (use-after-free bug fix) and provides context via a related PR link, but lacks required template sections like Overview, Details, Where to start, and Related Issues formatting. Complete the PR description by adding the template sections: Overview, Details, Where should the reviewer start, and properly formatted Related Issues with action keywords.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: Update AWS SDK version used' clearly and concisely describes the main change: updating the AWS SDK version from 1.11.581 to 1.11.760 in the vllm build configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aranadive
aranadive merged commit 6d8b5c4 into ai-dynamo:main Mar 4, 2026
83 of 84 checks passed
@aranadive
aranadive deleted the update_s3_sdk branch March 4, 2026 17:11
aranadive added a commit to aranadive/dynamo that referenced this pull request Mar 4, 2026
Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
saturley-hall pushed a commit that referenced this pull request Mar 4, 2026
Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
yao531441 pushed a commit to yao531441/dynamo that referenced this pull request May 13, 2026
Signed-off-by: Adit Ranadive <aranadive@nvidia.com>

This branch was previously deployed

1 inactive deployment
GITLAB — 4ef3bc46 Deployed Mar 3, 2026 by copy-pr-bot[bot] via Trigger CI Pipeline #19061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore container external-contribution Pull request is from an external contributor size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants