Skip to content

fix: set SGLANG_BLOCK_NONZERO_RANK_CHILDREN to be no-op #4527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ishandhanani merged 2 commits into from
Nov 21, 2025
Merged

fix: set SGLANG_BLOCK_NONZERO_RANK_CHILDREN to be no-op #4527

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ede3ef9
bump
ishandhanani Nov 21, 2025
f504ea0
rabbit
ishandhanani Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions components/src/dynamo/sglang/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,11 @@ async def init(runtime: DistributedRuntime, config: Config):
server_args, dynamo_args = config.server_args, config.dynamo_args

# Prevent SGLang from blocking on non-leader nodes
# We can switch this to 0 and leverage our own metrics
# after https://github.com/sgl-project/sglang/pull/13686
# is merged in
if server_args.node_rank >= 1:
os.environ["SGLANG_BLOCK_NONZERO_RANK_CHILDREN"] = "0"
os.environ["SGLANG_BLOCK_NONZERO_RANK_CHILDREN"] = "1"

engine = sgl.Engine(server_args=server_args)

Expand Down Expand Up @@ -188,8 +191,11 @@ async def init_prefill(runtime: DistributedRuntime, config: Config):
server_args, dynamo_args = config.server_args, config.dynamo_args

# Prevent SGLang from blocking on non-leader nodes
# We can switch this to 0 and leverage our own metrics
# after https://github.com/sgl-project/sglang/pull/13686
# is merged in
if server_args.node_rank >= 1:
os.environ["SGLANG_BLOCK_NONZERO_RANK_CHILDREN"] = "0"
os.environ["SGLANG_BLOCK_NONZERO_RANK_CHILDREN"] = "1"

engine = sgl.Engine(server_args=server_args)

Expand Down
Loading