Skip to content

fix: sglang worker log extraction error - #447

Merged
ryanolson merged 5 commits into
ai-dynamo:mainfrom
KivenChen:kiv__fix_sgl_log
Apr 1, 2025
Merged

ryanolson merged 5 commits into
ai-dynamo:mainfrom
KivenChen:kiv__fix_sgl_log

Conversation

@KivenChen

Copy link
Copy Markdown
Contributor

Overview:

Fix #361 and other potential log extraction issues for sglang workers.

Details:

The previous log extraction regex has an unreachable case (caps.len()==2, as caps always has 3 optional groups), which may misclassify or silence error logs. It might be necessary to clear the ambiguity.

Where should the reviewer start?

lib/llm/src/engines/sglang/worker.rs

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

@copy-pr-bot

copy-pr-bot Bot commented Mar 31, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi KivenChen! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions Bot added the external-contribution Pull request is from an external contributor label Mar 31, 2025

@ryanolson ryanolson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! lgtm

@ryanolson
ryanolson merged commit f613b8e into ai-dynamo:main Apr 1, 2025
@KivenChen
KivenChen deleted the kiv__fix_sgl_log branch April 2, 2025 18:28
kylehh pushed a commit to kylehh/dynamo that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contribution Pull request is from an external contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No error traceback for backend serving framework service start

2 participants