Repository navigation
fix: sglang worker log extraction error - #447
Merged
Merged
Conversation
KivenChen
requested review from
GuanLuo,
alec-flowers,
biswapanda,
grahamking,
kkranen,
paulhendricks,
rmccorm4,
ryanolson and
tmonty12
as code owners
March 31, 2025 09:33
Contributor
|
👋 Hi KivenChen! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Fix #361 and other potential log extraction issues for sglang workers.
Details:
The previous log extraction regex has an unreachable case (
caps.len()==2, ascapsalways has 3 optional groups), which may misclassify or silence error logs. It might be necessary to clear the ambiguity.Where should the reviewer start?
lib/llm/src/engines/sglang/worker.rs
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)