Repository navigation
feat: Extract Common Configs + Log Configs on Init + Add test_ to sdk/tests filenames required for pytest - #434
Merged
ishandhanani merged 51 commits intoApr 9, 2025
Conversation
jon-chuang
requested review from
GuanLuo,
PeaBrane,
alec-flowers,
biswapanda,
grahamking,
hhzhang16,
hutm,
ishandhanani,
julienmancuso,
kkranen,
mohammedabdulwahhab,
nnshah1,
paulhendricks,
piotrm-nvidia,
ptarasiewiczNV,
rmccorm4,
ryanolson,
sshchoi,
tanmayv25,
tedzhouhk and
tmonty12
as code owners
March 29, 2025 12:39
Contributor
|
👋 Hi jon-chuang! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
Contributor
Author
…/jon-chuang/dynamo into jon-chuang/extract-common-config
Contributor
Author
|
FYI @ishandhanani |
Contributor
Contributor
put a comment on other issue as well - but agree this is non obvious - if the test doesn't run after putting the mark let us know - and we'll be updating a testing strategy over the next weeks to make it clearer what is run when. |
nnshah1
reviewed
Apr 9, 2025
test_ file prefix required for pytest
test_ file prefix required for pytesttest_ to several test filenames required for pytest
test_ to several test filenames required for pytesttest_ to sdk test filenames required for pytest
test_ to sdk test filenames required for pytesttest_ to sdk/tests filenames required for pytest
Contributor
|
This last batch of commit messages are great @jon-chuang 😆 |
Contributor
|
Thanks for this @jon-chuang - merging to main |
This was referenced Apr 9, 2025
kylehh
pushed a commit
to kylehh/dynamo
that referenced
this pull request
Apr 11, 2025
…sdk/tests` filenames required for pytest (ai-dynamo#434) Co-authored-by: ishandhanani <82981111+ishandhanani@users.noreply.github.com>
oandreeva-nv
pushed a commit
that referenced
this pull request
Apr 22, 2025
…sdk/tests` filenames required for pytest (#434) Co-authored-by: ishandhanani <82981111+ishandhanani@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Overview:
Extracts common config
Details:
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Addresses:
dynamo serveHave components log their config #439CC @ryanolson
Validated working in my single node env
Tests now run successfully in CI
