-
Notifications
You must be signed in to change notification settings - Fork 1.3k
docs: reorganization of documentation structure for 0.6.0 #3750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
211bbab
fix: circular rust dynamo-parsers, dynamo-llm dependency (#3607) (#3…
saturley-hall 0b6ef5f
chore: update the relevant my-registry and my-tag (#3611)
saturley-hall a25268d
chore: typo and new commands (#3617) (#3625)
saturley-hall a61a800
feat: cherry pick PR#3306 benchmarks use aiperf (#3626)
saturley-hall c4b41fd
feat: add pre-deployment check for storageclass (#3573) (#3608)
biswapanda 58e063c
docs: Reorganize structure - move files to logical sections
athreesh 7988582
docs: Update all internal links to new structure
athreesh 1031848
docs: Fix hidden_toctree.rst paths
athreesh a4bd70e
docs: Add URL migration guide for external maintainers
athreesh 798c337
docs: Add reorganization summary
athreesh 3e72444
docs: Move kvbm/, planner/, router/ to top level
athreesh 50321ff
docs: Add final structure documentation
athreesh 013aa24
docs: Fix all internal links after docs reorganization
athreesh 5a34105
docs: Fix broken relative link to planner docs
athreesh 41c0585
docs: Remove leading slashes from README doc links
athreesh 66f6083
docs: Fix all broken documentation links after reorganization
athreesh 4e00ecc
Merge branch 'main' into docs-reorg
athreesh 7d69a60
Merge branch 'main' into docs-reorg
athreesh 165276f
chore: update sglang container and version (#3647)
ishandhanani ec47178
fix: cherrypick cuda 129 (#3652)
alec-flowers 23c6273
Merge branch 'main' into docs-reorg
athreesh cc220c6
Merge branch 'docs-reorg' of https://github.com/ai-dynamo/dynamo into…
athreesh c62ac73
Merge remote-tracking branch 'origin/main' into docs-reorg
athreesh af01be2
Merge docs-reorg into release/0.6.0
athreesh b52f23a
docs: fix broken links after documentation reorganization
dagil-nvidia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Risk of undefined variables and missing deployment verification.
This post-profile deployment logic has several critical issues:
Undefined variable risk: The variables
model_name(line 754),frontend_port(line 756), andconfig(line 757) are defined inside the try block (lines 121, 171, 721). If an exception occurs before these variables are set, this code will fail with aNameError.No deployment verification: The deployment is created (line 759) but there's no
await client.wait_for_deployment_ready()call. This means the function returns without confirming the deployment is functional.No error handling: There's no try-except block around the deployment creation. Deployment failures will either crash the script or leave broken deployments.
No cleanup mechanism: Unlike the deployments in the try block which are tracked in
deployment_clientsand cleaned up in the finally block, this deployment is never added to that list and has no cleanup path.Incomplete implementation: The TODO comments (lines 749-750) confirm that conflict checking and error handling are missing.
Consider this structure:
Additionally, move this block inside the try block (before line 736) or ensure all required variables are defined with fallback values before this block executes.
🤖 Prompt for AI Agents