Skip to content

fix: json strings should remain intact through profiler arg processin… #3689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saturley-hall merged 1 commit into from
Oct 17, 2025
Merged

fix: json strings should remain intact through profiler arg processin… #3689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions benchmarks/profiler/utils/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,17 @@ def break_arguments(args: list[str] | None) -> list[str]:
else:
for arg in args:
if arg is not None:
# Use shlex.split to properly handle quoted arguments
ans.extend(shlex.split(arg))
# If the arg looks like it might be JSON (starts with { or [) or is already a single token,
# don't split it further. Only split if it contains spaces AND doesn't look like JSON.
if (
isinstance(arg, str)
and (" " in arg or "\t" in arg)
and not (arg.strip().startswith(("{", "[")))
):
# Use shlex.split to properly handle quoted arguments
ans.extend(shlex.split(arg))
else:
ans.append(arg)
return ans


Expand Down Expand Up @@ -971,7 +980,9 @@ def convert_config(
# - Disable enable_block_reuse (no KV reuse for prefill-only)
# - Enable overlap scheduler (disabled in prefill.yaml but needed for agg)
# - Remove cache_transceiver_config (not needed in agg mode)
if "kv_cache_config" not in override_dict:
if "kv_cache_config" not in override_dict or not isinstance(
override_dict["kv_cache_config"], dict
):
override_dict["kv_cache_config"] = {}
override_dict["kv_cache_config"]["enable_block_reuse"] = False
override_dict[
Expand Down Expand Up @@ -1022,7 +1033,9 @@ def convert_config(
# Merge our overrides for converting decode-only disagg to aggregated:
# - Enable enable_block_reuse (to skip prefill in decode-only)
# - Remove cache_transceiver_config (not needed in agg mode)
if "kv_cache_config" not in override_dict:
if "kv_cache_config" not in override_dict or not isinstance(
override_dict["kv_cache_config"], dict
):
override_dict["kv_cache_config"] = {}
override_dict["kv_cache_config"]["enable_block_reuse"] = True
override_dict[
Expand Down
Loading