Repository navigation
fix: limit rust build parallel jobs - #366
Merged
Merged
Conversation
tedzhouhk
requested review from
alec-flowers,
ishandhanani,
nnshah1,
ptarasiewiczNV,
rmccorm4 and
tanmayv25
as code owners
March 24, 2025 16:31
Contributor
Author
|
/ok to test |
grahamking
reviewed
Mar 24, 2025
grahamking
approved these changes
Mar 24, 2025
grahamking
left a comment
grahamking
left a comment
Contributor
There was a problem hiding this comment.
It's a sad day that our beautiful build machines can only do 16 parallel builds. What have we done.
tedzhouhk
enabled auto-merge (squash)
March 25, 2025 20:13
Contributor
|
@tedzhouhk Can you make a similar change to Dockerfile.tensorrt_llm ? |
Contributor
Author
|
@tanmayv25 done, please review again. thanks |
tanmayv25
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, cargo build num of cpu core jobs in parallel. Limiting the max parallel job build fix the random error of exceeding ulimit on opened files.