Skip to content

fix: copy commit info in trtllm build#3619

Merged
nv-anants merged 2 commits into
mainfrom
anants/5579186
Oct 16, 2025
Merged

fix: copy commit info in trtllm build#3619
nv-anants merged 2 commits into
mainfrom
anants/5579186

Conversation

@nv-anants
Copy link
Copy Markdown
Member

@nv-anants nv-anants commented Oct 14, 2025

Overview:

copy commit.txt file trtllm_wheel image context

Summary by CodeRabbit

  • Chores
    • Container images now include commit metadata text files alongside installed wheels for TensorRT-LLM components.
    • Build process updated to copy both wheel and commit info artifacts into the final image, ensuring metadata is available.
    • Inline comment adjusted to reflect the inclusion of commit information.
    • No runtime behavior changes; application functionality remains the same.

Signed-off-by: Anant Sharma <anants@nvidia.com>
Signed-off-by: Anant Sharma <anants@nvidia.com>
@nv-anants nv-anants marked this pull request as ready for review October 14, 2025 22:15
@nv-anants nv-anants requested a review from a team October 14, 2025 22:15
@nv-anants nv-anants requested review from a team as code owners October 14, 2025 22:15
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 14, 2025

Walkthrough

The Dockerfile for the TRT LLM container now copies both wheel (.whl) and commit info (.txt) artifacts from the trtllm_wheel stage into the image. The related comment was updated to mention commit info.

Changes

Cohort / File(s) Summary of changes
Docker build assets
container/Dockerfile.trtllm
Added COPY for *.txt from trtllm_wheel alongside existing *.whl copy; updated comment to reflect commit info inclusion.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I hop through layers, crisp and light,
Copying wheels and notes just right.
A txt crumb, a whl treat—
Docker burrow now complete.
Thump-thump logs: commit in sight! 🐇✨

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description only includes an Overview section and omits the required Details, Where should the reviewer start, and Related Issues sections specified in the repository template, leaving out essential context and guidance for reviewers. Please expand the description to include a Details section that explains the exact changes made, specify which files or sections reviewers should focus on, and add a Related Issues section linking any relevant issue numbers using the appropriate action keywords.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly and concisely describes the primary change in the pull request, namely copying commit information in the trtllm build, and it directly matches the modification made in the Dockerfile without unnecessary detail or noise.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5cbfc27 and cf3ff08.

📒 Files selected for processing (1)
  • container/Dockerfile.trtllm (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nv-anants nv-anants merged commit 3d7f7a5 into main Oct 16, 2025
21 of 22 checks passed
@nv-anants nv-anants deleted the anants/5579186 branch October 16, 2025 13:21
nv-anants added a commit that referenced this pull request Oct 16, 2025
Signed-off-by: Anant Sharma <anants@nvidia.com>
saturley-hall pushed a commit that referenced this pull request Oct 16, 2025
Signed-off-by: Anant Sharma <anants@nvidia.com>
athreesh pushed a commit that referenced this pull request Oct 16, 2025
Signed-off-by: Anant Sharma <anants@nvidia.com>
ziqifan617 pushed a commit that referenced this pull request Oct 20, 2025
Signed-off-by: Anant Sharma <anants@nvidia.com>
yao531441 pushed a commit to yao531441/dynamo that referenced this pull request May 13, 2026
Signed-off-by: Anant Sharma <anants@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants