chore: typo and new commands#3617
Conversation
WalkthroughThe deployment YAML fixes the container command from python3E to python3 for prefill and decode. The launch script removes expert-distribution recording setup and switches worker flags to round-robin load balancing for prefill and a prefill round-robin balance flag for decode. No other arguments or control flow changes. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant User as Operator
participant Launch as disagg_dp_attn.sh
participant Prefill as Prefill Worker
participant Decode as Decode Worker
participant Deploy as disagg.yaml
Note over Deploy: Container command uses python3 (fixed)
User->>Launch: Run launch script
Launch->>Prefill: Start with --load-balance-method round_robin
Launch->>Decode: Start with --prefill-round-robin-balance
Note over Launch,Prefill: Removed expert distribution recorder setup
Prefill-->>Launch: Ready
Decode-->>Launch: Ready
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used🧬 Code graph analysis (1)components/backends/sglang/launch/disagg_dp_attn.sh (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/ok to test d6dcaed |
Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com>
Fixes 2 release bugs
Summary by CodeRabbit