Skip to content

chore: typo and new commands#3617

Merged
ishandhanani merged 2 commits into
mainfrom
ishan/fixes
Oct 14, 2025
Merged

chore: typo and new commands#3617
ishandhanani merged 2 commits into
mainfrom
ishan/fixes

Conversation

@ishandhanani
Copy link
Copy Markdown
Contributor

@ishandhanani ishandhanani commented Oct 14, 2025

Fixes 2 release bugs

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the Python interpreter used by prefill and decode containers to ensure reliable startup and execution.
  • Refactor
    • Switched prefill and decode workers to round-robin load balancing for more predictable distribution.
  • Chores
    • Removed creation of the expert distribution recording directory and related environment variable to streamline startup.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 14, 2025

Walkthrough

The deployment YAML fixes the container command from python3E to python3 for prefill and decode. The launch script removes expert-distribution recording setup and switches worker flags to round-robin load balancing for prefill and a prefill round-robin balance flag for decode. No other arguments or control flow changes.

Changes

Cohort / File(s) Summary
Deployment config command fix
components/backends/sglang/deploy/disagg.yaml
Corrected container command interpreter from python3E to python3 for prefill and decode entries; no other config changes.
Launch script flag updates
components/backends/sglang/launch/disagg_dp_attn.sh
Removed expert distribution recording dir/env setup; replaced --expert-distribution-recorder-mode stat with --load-balance-method round_robin (prefill) and --prefill-round-robin-balance (decode).

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant User as Operator
  participant Launch as disagg_dp_attn.sh
  participant Prefill as Prefill Worker
  participant Decode as Decode Worker
  participant Deploy as disagg.yaml

  Note over Deploy: Container command uses python3 (fixed)
  User->>Launch: Run launch script
  Launch->>Prefill: Start with --load-balance-method round_robin
  Launch->>Decode: Start with --prefill-round-robin-balance
  Note over Launch,Prefill: Removed expert distribution recorder setup
  Prefill-->>Launch: Ready
  Decode-->>Launch: Ready
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my ears at flags anew,
Round-robin hops, a balanced queue.
Python’s path now clear and bright,
No stray E to steal the night.
I thump, deploy, then swiftly go—
Prefill, decode, in perfect flow. 🐇✨

Pre-merge checks

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description provides only a brief statement “Fixes 2 release bugs” and does not follow the repository’s required template. It lacks an Overview, Details on the changes, guidance on where reviewers should start, and any Related Issues section. Without these structured sections, reviewers do not have the context or specific pointers needed to evaluate the pull request effectively. Please expand the description to match the repository template by adding an Overview that summarizes the purpose of the bug fixes, a Details section outlining the specific changes in each file, a “Where should the reviewer start?” section listing key files to review, and a Related Issues section that closes or references the appropriate issue numbers.
Title Check ❓ Inconclusive The title “chore: typo and new commands” is too vague to clearly communicate the main changes in this pull request. It mentions a “typo” and “new commands” without specifying that it corrects the Python interpreter invocation in disagg.yaml or updates load balancing flags in the launch script. This lack of detail makes it hard for other team members to understand the primary purpose at a glance. Please update the title to more specifically reflect the key changes, for example by referencing the corrected Python3E interpreter invocation and the adjustment of load-balancing flags in the disagg deployment and launch scripts; a concise yet descriptive title will help teammates quickly grasp the main purpose of the pull request.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a55fa9 and d6dcaed.

📒 Files selected for processing (2)
  • components/backends/sglang/deploy/disagg.yaml (1 hunks)
  • components/backends/sglang/launch/disagg_dp_attn.sh (2 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
components/backends/sglang/launch/disagg_dp_attn.sh (1)
lib/bindings/python/rust/lib.rs (1)
  • round_robin (760-794)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: trtllm (amd64)
  • GitHub Check: vllm (amd64)
  • GitHub Check: vllm (arm64)
  • GitHub Check: sglang
  • GitHub Check: Build and Test - dynamo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ishandhanani ishandhanani enabled auto-merge (squash) October 14, 2025 19:18
@ishandhanani ishandhanani requested a review from PeaBrane October 14, 2025 19:18
@ishandhanani
Copy link
Copy Markdown
Contributor Author

/ok to test d6dcaed

@ishandhanani ishandhanani merged commit 4c4130e into main Oct 14, 2025
20 checks passed
@ishandhanani ishandhanani deleted the ishan/fixes branch October 14, 2025 20:11
saturley-hall pushed a commit that referenced this pull request Oct 14, 2025
Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com>
saturley-hall added a commit that referenced this pull request Oct 14, 2025
Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com>
Co-authored-by: ishandhanani <82981111+ishandhanani@users.noreply.github.com>
shpgy-shpgy pushed a commit to shpgy-shpgy/dynamo that referenced this pull request Oct 15, 2025
ziqifan617 pushed a commit that referenced this pull request Oct 20, 2025
nv-tusharma pushed a commit that referenced this pull request Oct 20, 2025
yao531441 pushed a commit to yao531441/dynamo that referenced this pull request May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants