test: Break parsers -> llm dependency#3607
Merged
Merged
Conversation
The `parsers` crate is intended to be standalone, it cannot depend on `llm`. There was an integration test in there that used llm. This PR moves that test to the llm crate. Signed-off-by: Graham King <grahamk@nvidia.com>
Contributor
WalkthroughRemoved a dev-only dependency from lib/parsers/Cargo.toml and deleted the test module content in lib/parsers/tests/mod.rs. No runtime dependencies or public APIs were altered. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
saturley-hall
pushed a commit
that referenced
this pull request
Oct 14, 2025
Signed-off-by: Graham King <grahamk@nvidia.com> Signed-off-by: Harrison Saturley-Hall <hsaturleyhal@nvidia.com>
saturley-hall
added a commit
that referenced
this pull request
Oct 14, 2025
shpgy-shpgy
pushed a commit
to shpgy-shpgy/dynamo
that referenced
this pull request
Oct 15, 2025
Signed-off-by: Graham King <grahamk@nvidia.com>
ziqifan617
pushed a commit
that referenced
this pull request
Oct 20, 2025
Signed-off-by: Graham King <grahamk@nvidia.com>
nv-tusharma
pushed a commit
that referenced
this pull request
Oct 20, 2025
Signed-off-by: Graham King <grahamk@nvidia.com>
yao531441
pushed a commit
to yao531441/dynamo
that referenced
this pull request
May 13, 2026
Signed-off-by: Graham King <grahamk@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
parserscrate is intended to be standalone, it cannot depend onllm. There was an integration test in there that used llm. This PR moves that test to the llm crate.