feat: guides for nixl benchmarking#3584
Conversation
9c079f9 to
20c34fc
Compare
20c34fc to
0b1357a
Compare
|
Caution Review failedFailed to post review comments WalkthroughAdds Kubernetes pre-deployment checks and NIXL benchmark build/deploy tooling. Introduces two new Bash scripts, updates NIXL deployment YAML, replaces/relocates NIXL documentation, and removes an old benchmark README. No application code or APIs changed. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant S as pre-deployment-check.sh
participant K as kubectl
participant API as Kubernetes API
U->>S: Run script
S->>K: kubectl version / cluster-info
K->>API: Connect
API-->>K: Response
K-->>S: Status
S->>K: Get default StorageClass
K-->>S: SC list/labels
S->>K: Get GPU nodes (labels/resources)
K-->>S: Node counts
S->>K: Check GPU operator pods
K-->>S: Pod states
S-->>U: Per-check results and overall summary (PASS/FAIL), exit code
sequenceDiagram
autonumber
actor U as User
participant B as build_and_deploy.sh
participant FS as Filesystem
participant D as Docker/Build
participant R as Registry
participant K as kubectl
participant API as Kubernetes API
U->>B: Start script (select arch, steps)
alt Build image
B->>FS: Fetch NIXL source
B->>D: docker build -t REG/nixlbench:VERSION-ARCH
D->>R: Push (if configured)
R-->>B: Image available
end
alt Update YAML
B->>FS: Copy base YAML -> arch-specific file
B->>FS: Update image ref via sed
end
alt Deploy
B->>K: kubectl apply -f arch-specific YAML
K->>API: Create/Update resources
API-->>K: Status
K-->>B: Apply result
end
B-->>U: Summary and follow-up commands
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
Pre-merge checks❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
atchernych
left a comment
There was a problem hiding this comment.
some nice to haves, i think quotes are important
makes sense @atchernych. |
d2b3941
into
bis/dep-461-check-default-storage-class-before-deployment
Overview:
This guide describes how to build and deploy the NIXL benchmark using the provided scripts on a Kubernetes (K8s) cluster.
Summary by CodeRabbit
New Features
Documentation