Skip to content

docs: Add deprecation notices for unused Docker build arguments (no code change at all) #3568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
Merged

docs: Add deprecation notices for unused Docker build arguments (no code change at all) #3568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions container/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,6 +591,13 @@ if [[ $TARGET == "local-dev" ]]; then
TARGET_STR="--target dev"
fi

# DEPRECATION: The following build args are not currently used by any Dockerfile and will be removed soon:
# - FRAMEWORK
# - VLLM_FRAMEWORK (or TRTLLM_FRAMEWORK, SGLANG_FRAMEWORK, etc.)
# - VERSION
# - PYTHON_PACKAGE_VERSION
# - HF_TOKEN

# BUILD DEV IMAGE

BUILD_ARGS+=" --build-arg BASE_IMAGE=$BASE_IMAGE --build-arg BASE_IMAGE_TAG=$BASE_IMAGE_TAG --build-arg FRAMEWORK=$FRAMEWORK --build-arg ${FRAMEWORK}_FRAMEWORK=1 --build-arg VERSION=$VERSION --build-arg PYTHON_PACKAGE_VERSION=$PYTHON_PACKAGE_VERSION"
Expand Down Expand Up @@ -752,11 +759,27 @@ if [[ -z "${DEV_IMAGE_INPUT:-}" ]]; then
echo "======================================"
echo "Starting Build 1: Base Image"
echo "======================================"
# Build 1 (container/Dockerfile) does NOT use (will be removed soon):
# - FRAMEWORK
# - VLLM_FRAMEWORK (or TRTLLM_FRAMEWORK, SGLANG_FRAMEWORK, etc.)
# - VERSION
# - PYTHON_PACKAGE_VERSION
# - HF_TOKEN
# - MAX_JOBS
$RUN_PREFIX docker build -f "${SOURCE_DIR}/Dockerfile" --target dev $PLATFORM $BUILD_ARGS $CACHE_FROM $CACHE_TO --tag $DYNAMO_BASE_IMAGE $BUILD_CONTEXT_ARG $BUILD_CONTEXT $NO_CACHE
# Start framework build
echo "======================================"
echo "Starting Build 2: Framework Image"
echo "======================================"
# Build 2 (container/Dockerfile.vllm or .trtllm, .sglang) does NOT use (will be removed soon):
# - FRAMEWORK
# - VLLM_FRAMEWORK (or TRTLLM_FRAMEWORK, SGLANG_FRAMEWORK, etc.)
# - VERSION
# - PYTHON_PACKAGE_VERSION
# - HF_TOKEN
# - NIXL_REF
# - NIXL_UCX_REF
# - ENABLE_KVBM
BUILD_ARGS+=" --build-arg DYNAMO_BASE_IMAGE=${DYNAMO_BASE_IMAGE}"
$RUN_PREFIX docker build -f $DOCKERFILE $TARGET_STR $PLATFORM $BUILD_ARGS $CACHE_FROM $CACHE_TO $TAG $LATEST_TAG $BUILD_CONTEXT_ARG $BUILD_CONTEXT $NO_CACHE
else
Expand Down
Loading