Skip to content

chore: Remove clear_namespace script #3519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2025
Merged

chore: Remove clear_namespace script #3519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions components/backends/sglang/launch/agg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ cleanup() {
}
trap cleanup EXIT INT TERM

# run clear_namespace
python3 -m dynamo.sglang.clear_namespace --namespace dynamo

# run ingress
python3 -m dynamo.frontend --http-port=8000 &
Expand Down
2 changes: 0 additions & 2 deletions components/backends/sglang/launch/agg_embed.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ cleanup() {
}
trap cleanup EXIT INT TERM

# run clear_namespace
python3 -m dynamo.sglang.utils.clear_namespace --namespace dynamo

# run ingress
python3 -m dynamo.frontend --http-port=8000 &
Expand Down
2 changes: 0 additions & 2 deletions components/backends/sglang/launch/agg_router.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ cleanup() {
}
trap cleanup EXIT INT TERM

# run clear_namespace
python3 -m dynamo.sglang.clear_namespace --namespace dynamo

# run ingress
python -m dynamo.frontend --router-mode kv --http-port=8000 &
Expand Down
2 changes: 0 additions & 2 deletions components/backends/sglang/launch/disagg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ cleanup() {
}
trap cleanup EXIT INT TERM

# run clear_namespace
python3 -m dynamo.sglang.clear_namespace --namespace dynamo

# run ingress
python3 -m dynamo.frontend --http-port=8000 &
Expand Down
2 changes: 0 additions & 2 deletions components/backends/sglang/launch/disagg_dp_attn.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ cleanup() {
}
trap cleanup EXIT INT TERM

# run clear_namespace
python3 -m dynamo.sglang.clear_namespace --namespace dynamo

# run ingress
python3 -m dynamo.frontend --http-port=8000 &
Expand Down
2 changes: 0 additions & 2 deletions components/backends/sglang/launch/multimodal_agg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ fi
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
SGLANG_BACKEND_DIR="$SCRIPT_DIR/src"

# run clear_namespace
python3 -m dynamo.sglang.clear_namespace --namespace dynamo

# run ingress
python3 -m dynamo.frontend --http-port=8000 &
Expand Down
2 changes: 0 additions & 2 deletions components/backends/sglang/launch/multimodal_disagg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ fi
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
SGLANG_BACKEND_DIR="$SCRIPT_DIR/src"

# run clear_namespace
python3 -m dynamo.sglang.clear_namespace --namespace dynamo

# run ingress
python3 -m dynamo.frontend --http-port=8000 &
Expand Down
5 changes: 1 addition & 4 deletions components/backends/trtllm/gpt-oss.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,13 +134,10 @@ cd /workspace/components/backends/trtllm

#### Option B: Manual Launch

1. **Clear namespace and start frontend**:
1. **Start frontend**:
```bash
cd /workspace/dynamo/components/backends/trtllm

# Clear any existing deployments
python3 utils/clear_namespace.py --namespace dynamo

# Start frontend with round-robin routing
python3 -m dynamo.frontend --router-mode round-robin --http-port 8000 &
```
Expand Down
2 changes: 0 additions & 2 deletions components/backends/trtllm/launch/agg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ cleanup() {
}
trap cleanup EXIT INT TERM

# run clear_namespace
python3 utils/clear_namespace.py --namespace dynamo

# run frontend
python3 -m dynamo.frontend --http-port 8000 &
Expand Down
3 changes: 0 additions & 3 deletions components/backends/trtllm/launch/agg_metrics.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ cleanup() {
}
trap cleanup EXIT INT TERM

# Run clear_namespace
python3 utils/clear_namespace.py --namespace dynamo

# Run frontend
python3 -m dynamo.frontend --http-port 8000 &
DYNAMO_PID=$!
Expand Down
2 changes: 0 additions & 2 deletions components/backends/trtllm/launch/agg_router.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ cleanup() {
}
trap cleanup EXIT INT TERM

# run clear_namespace
python3 utils/clear_namespace.py --namespace dynamo

# run frontend
python3 -m dynamo.frontend --router-mode kv --http-port 8000 &
Expand Down
2 changes: 0 additions & 2 deletions components/backends/trtllm/launch/disagg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ cleanup() {
}
trap cleanup EXIT INT TERM

# run clear_namespace
python3 utils/clear_namespace.py --namespace dynamo

# run frontend
python3 -m dynamo.frontend --http-port 8000 &
Expand Down
2 changes: 0 additions & 2 deletions components/backends/trtllm/launch/disagg_router.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ cleanup() {
}
trap cleanup EXIT INT TERM

# run clear_namespace
python3 utils/clear_namespace.py --namespace dynamo

# run frontend
python3 -m dynamo.frontend --router-mode kv --http-port 8000 &
Expand Down
2 changes: 0 additions & 2 deletions components/backends/trtllm/launch/epd_disagg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ cleanup() {
}
trap cleanup EXIT INT TERM

# run clear_namespace
python3 utils/clear_namespace.py --namespace dynamo

# run frontend
python3 -m dynamo.frontend --http-port 8000 &
Expand Down
2 changes: 0 additions & 2 deletions components/backends/trtllm/launch/gpt_oss_disagg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ export DECODE_ENGINE_ARGS=${DECODE_ENGINE_ARGS:-"engine_configs/gpt_oss/decode.y
set -e
trap 'echo Cleaning up...; kill 0' EXIT

# run clear_namespace
python3 utils/clear_namespace.py --namespace dynamo

# run frontend
python3 -m dynamo.frontend --router-mode round-robin --http-port 8000 &
Expand Down
25 changes: 0 additions & 25 deletions components/backends/trtllm/utils/clear_namespace.py
View file
Open in desktop

This file was deleted.

27 changes: 0 additions & 27 deletions components/src/dynamo/sglang/clear_namespace.py
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions lib/bindings/python/rust/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,15 +424,6 @@ impl DistributedRuntime {
})
}

/// Remove everything in an etcd namespace.
/// Will be removed once we can clear the MDC automatically.
fn temp_clear_namespace<'p>(&self, py: Python<'p>, name: String) -> PyResult<Bound<'p, PyAny>> {
let inner = self.inner.clone();
pyo3_async_runtimes::tokio::future_into_py(py, async move {
inner.temp_clear_namespace(&name).await.map_err(to_pyerr)
})
}

fn namespace(&self, name: String) -> PyResult<Namespace> {
Ok(Namespace {
inner: self.inner.namespace(name).map_err(to_pyerr)?,
Expand Down
13 changes: 0 additions & 13 deletions lib/runtime/src/distributed.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,19 +329,6 @@ impl DistributedRuntime {
}
}

/// Clear everything in etcd under a key.
/// todo: Remove as soon as we auto-delete the MDC.
pub async fn temp_clear_namespace(&self, name: &str) -> anyhow::Result<()> {
let Some(etcd_client) = self.etcd_client() else {
return Ok(()); // no etcd, nothing to clear
};
let kvs = etcd_client.kv_get_prefix(name).await?;
for kv in kvs {
etcd_client.kv_delete(kv.key(), None).await?;
}
Ok(())
}

/// Get all registered hierarchy keys. Private because it is only used for testing.
fn get_registered_hierarchies(&self) -> Vec<String> {
let registries = self.hierarchy_to_metricsregistry.read().unwrap();
Expand Down
3 changes: 0 additions & 3 deletions tests/serve/launch/sglang_agg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ cleanup() {
}
trap cleanup EXIT INT TERM

# run clear_namespace
python3 -m dynamo.sglang.clear_namespace --namespace dynamo

# run ingress
python3 -m dynamo.frontend --http-port=8000 &
DYNAMO_PID=$!
Expand Down
Loading