-
Notifications
You must be signed in to change notification settings - Fork 658
fix: Add support for single element arrays for chat and completions prompts #3482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zhongdaor-nv
merged 14 commits into
main
from
zhongdaor/dis-717-open-ai-chat-completion-prompt-is-not-respected-if-we-send
Oct 14, 2025
Merged
fix: Add support for single element arrays for chat and completions prompts #3482
zhongdaor-nv
merged 14 commits into
main
from
zhongdaor/dis-717-open-ai-chat-completion-prompt-is-not-respected-if-we-send
Oct 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhongdaor <[email protected]>
|
make engine works when prompt is a array of string |
|
This is just a simple fix. #1648 |
…ompt-is-not-respected-if-we-send
Signed-off-by: zhongdaor <[email protected]>
…ompt-is-not-respected-if-we-send
Signed-off-by: zhongdaor <[email protected]>
Signed-off-by: zhongdaor <[email protected]>
…ompt-is-not-respected-if-we-send
Signed-off-by: zhongdaor <[email protected]>
rmccorm4
reviewed
Oct 11, 2025
rmccorm4
reviewed
Oct 11, 2025
rmccorm4
reviewed
Oct 11, 2025
rmccorm4
reviewed
Oct 11, 2025
rmccorm4
reviewed
Oct 11, 2025
rmccorm4
reviewed
Oct 11, 2025
Signed-off-by: zhongdaor <[email protected]>
Signed-off-by: zhongdaor <[email protected]>
Signed-off-by: zhongdaor <[email protected]>
GuanLuo
approved these changes
Oct 14, 2025
…ompt-is-not-respected-if-we-send
shpgy-shpgy
pushed a commit
to shpgy-shpgy/dynamo
that referenced
this pull request
Oct 15, 2025
…rompts (ai-dynamo#3482) Signed-off-by: zhongdaor <[email protected]>
ziqifan617
pushed a commit
that referenced
this pull request
Oct 20, 2025
…rompts (#3482) Signed-off-by: zhongdaor <[email protected]>
nv-tusharma
pushed a commit
that referenced
this pull request
Oct 20, 2025
…rompts (#3482) Signed-off-by: zhongdaor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit