Skip to content

feat: update gpt-oss 120b model recipe #3143 #3454#3431

Merged
saturley-hall merged 2 commits into
release/0.5.1from
bis/cp-gpt-oss-120b
Oct 7, 2025
Merged

feat: update gpt-oss 120b model recipe #3143 #3454#3431
saturley-hall merged 2 commits into
release/0.5.1from
bis/cp-gpt-oss-120b

Conversation

@biswapanda
Copy link
Copy Markdown
Contributor

@biswapanda biswapanda commented Oct 6, 2025

Overview:

Cherry pick

closes: DEP-410

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

Summary by CodeRabbit

  • New Features

    • Added CLI controls for request synthesis (min/max input/output lengths).
    • Container run script now supports --network modes and -p port mappings.
    • Introduced GPT-OSS-120B deployment recipe and artifacts.
  • Bug Fixes

    • More robust streaming completion handling and finish_reason standardization.
  • Improvements

    • Increased default KV Router snapshot threshold for better scalability.
    • Upgraded default images across backends to 0.5.1; Helm charts bumped.
    • Enhanced NATS stream readiness and purge behavior.
    • Refined Docker build flows (RDMA reinstall, TRT-LLM setup) and benchmarks packaging.
  • Documentation

    • Extensive updates: image/tag references, runtime guides, ECS/Fargate steps, networking guidance, and example renames.

Signed-off-by: Biswa Panda <biswa.panda@gmail.com>
@biswapanda biswapanda requested a review from a team as a code owner October 6, 2025 16:09
@biswapanda biswapanda requested a review from a team October 6, 2025 16:09
@biswapanda biswapanda requested review from a team as code owners October 6, 2025 16:09
@github-actions github-actions Bot added the feat label Oct 6, 2025
@biswapanda biswapanda changed the base branch from main to release/0.5.1 October 6, 2025 16:10
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 6, 2025

Caution

Review failed

Failed to post review comments

Pre-merge checks

❌ Failed checks (3 warnings)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The title only references updating the GPT-OSS 120B recipe but the changeset spans extensive container image bumps to v0.5.1, new CLI flags, Dockerfile overhaul, documentation updates, and configuration tweaks across many components; it fails to summarize the primary scope of the patch accurately and is misleadingly narrow. Please revise the title to reflect the full scope of the changes, for example “chore: bump container images to v0.5.1 across components and cherry-pick GPT-OSS 120B recipe updates,” or split this broad changeset into focused PRs.
Description Check ⚠️ Warning The description includes the template headings but leaves the Details and Where should the reviewer start sections empty and uses a placeholder issue number, so it provides no substantive summary of the actual changes or guidance on key files to review. Complete the Details section with an overview of the modifications made (e.g., image tag updates, CLI enhancements, Dockerfile changes, recipe additions), list the primary files or directories reviewers should examine, and update the Related Issues section with the correct issue references.
Docstring Coverage ⚠️ Warning Docstring coverage is 30.43% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Oct 7, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@biswapanda biswapanda changed the title feat: update gpt-oss 120b model recipe #3143 feat: update gpt-oss 120b model recipe #3143 #3454 Oct 7, 2025
@saturley-hall saturley-hall merged commit 99f1696 into release/0.5.1 Oct 7, 2025
12 checks passed
@saturley-hall saturley-hall deleted the bis/cp-gpt-oss-120b branch October 7, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants