Skip to content

fix: etcd bucket delete missing prefix and metrics test range #3331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
Merged

fix: etcd bucket delete missing prefix and metrics test range #3331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/runtime/src/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1593,8 +1593,8 @@ mod test_metricsregistry_nats {
(
build_component_metric_name(nats_service::REQUESTS_TOTAL),
0.0,
0.0,
), // No work handler requests
10.0,
), // NATS service stats requests (may differ from work handler count)
(
build_component_metric_name(nats_service::PROCESSING_MS_TOTAL),
0.0,
Expand Down
6 changes: 4 additions & 2 deletions lib/runtime/src/storage/key_value_store/etcd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ impl KeyValueBucket for EtcdBucket {
}

async fn get(&self, key: &Key) -> Result<Option<bytes::Bytes>, StorageError> {
let k = format!("{}/{key}", self.bucket_name);
let k = make_key(&self.bucket_name, key);
tracing::trace!("etcd get: {k}");

let mut kvs = self
Expand All @@ -86,9 +86,11 @@ impl KeyValueBucket for EtcdBucket {
}

async fn delete(&self, key: &Key) -> Result<(), StorageError> {
let k = make_key(&self.bucket_name, key);
tracing::trace!("etcd delete: {k}");
let _ = self
.client
.kv_delete(key.0.clone(), None)
.kv_delete(k, None)
.await
.map_err(|e| StorageError::EtcdError(e.to_string()))?;
Ok(())
Expand Down
Loading