- 
                Notifications
    You must be signed in to change notification settings 
- Fork 663
feat: add e2e dynamo deploy tests #3243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 5 commits
      Commits
    
    
            Show all changes
          
          
            84 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      ccf7194
              
                Added pre-merge-e2e.yml setup before and after script.
              
              
                dmitry-tokarev-nv 66ca5e3
              
                cleanup
              
              
                dmitry-tokarev-nv 35b19b8
              
                Merge branch 'main' of github.com:ai-dynamo/dynamo into dtokarev-e2e
              
              
                dillon-cullinan 54ba81b
              
                Add docker tag and push
              
              
                dillon-cullinan 3a695da
              
                vix env vars
              
              
                dmitry-tokarev-nv e5a94cd
              
                Added ACR login. Renamed some vars
              
              
                dmitry-tokarev-nv 1d67927
              
                secret. >> secrets.
              
              
                dmitry-tokarev-nv 9899736
              
                Add sudo, add container push to sglang and vllm
              
              
                dillon-cullinan ab487f2
              
                Install uv, fix action path
              
              
                dillon-cullinan 1aa0bc8
              
                Update tag and push action
              
              
                dillon-cullinan a24246c
              
                Fix var names
              
              
                dillon-cullinan ea22c83
              
                Move input vars into steps directly
              
              
                dillon-cullinan bf1dd25
              
                Fix vars
              
              
                dillon-cullinan 7caa1a6
              
                Set run shell
              
              
                dillon-cullinan 5f7d507
              
                Remove global vars
              
              
                dillon-cullinan 7808410
              
                trailing space
              
              
                dmitry-tokarev-nv 3e14f48
              
                remove uv, set -x
              
              
                dmitry-tokarev-nv e9c181d
              
                added missed chmod and fail-fast: false
              
              
                dmitry-tokarev-nv b528c14
              
                fail-fast: false
              
              
                dmitry-tokarev-nv fcbdfe3
              
                Install awscli for docker push
              
              
                dillon-cullinan 50d9d26
              
                Fix chmod on kubectl
              
              
                dillon-cullinan ccdc3ad
              
                Move docker tag/push before tests
              
              
                dillon-cullinan 29c8d7c
              
                Remove AWS login, it is now provided by pod service account
              
              
                dillon-cullinan 019bf03
              
                Re-add login...
              
              
                dillon-cullinan b8ce72c
              
                Fix if statement for ACR tag and push
              
              
                dillon-cullinan a6ac1d5
              
                Comment out helm repo add/update in beforescript
              
              
                dillon-cullinan 32f9cc5
              
                Comment out env and cd command
              
              
                dillon-cullinan 376f979
              
                update location
              
              
                nv-anants 86a93f3
              
                run everyhting in before scr
              
              
                nv-anants 96b098e
              
                debug
              
              
                nv-anants 0c36041
              
                add operator build
              
              
                nv-anants 4bab7e3
              
                add secrets
              
              
                nv-anants f4ef624
              
                add everthing
              
              
                nv-anants 8540646
              
                use docker build
              
              
                nv-anants d3f4bec
              
                push image
              
              
                nv-anants f0d1f14
              
                Merge branch 'main' into dtokarev-e2e
              
              
                nv-anants 952f8d7
              
                revert build.sh changes
              
              
                nv-anants cb6e511
              
                deploy only once
              
              
                nv-anants fc666c3
              
                tests
              
              
                nv-anants 2c41ff9
              
                deps
              
              
                nv-anants 7f1a16b
              
                merge
              
              
                nv-anants ef60527
              
                test
              
              
                nv-anants fa90a05
              
                cleanup
              
              
                nv-anants d06a371
              
                add test
              
              
                nv-anants 878850c
              
                debug
              
              
                nv-anants 281fa3b
              
                debug2
              
              
                nv-anants c0900b4
              
                sleep less
              
              
                nv-anants 8cd1c83
              
                debug
              
              
                nv-anants b5fc5fa
              
                switch image
              
              
                nv-anants 53343df
              
                test
              
              
                nv-anants 11430d5
              
                fix: fix
              
              
                mohammedabdulwahhab 5ec9b0f
              
                fix: use hf secret
              
              
                mohammedabdulwahhab 67bef0a
              
                Merge branch 'main' into dtokarev-e2e
              
              
                dillon-cullinan f5c5fde
              
                Comment out workflow metrics temporarily
              
              
                dillon-cullinan 6ebc651
              
                Merge branch 'main' into dtokarev-e2e
              
              
                nv-anants 2605c34
              
                Merge branch 'main' into dtokarev-e2e
              
              
                nv-anants e80844c
              
                temp: disable cleanup
              
              
                nv-anants a83dc3c
              
                fix: merge commit
              
              
                mohammedabdulwahhab 0e870b7
              
                refactor
              
              
                nv-anants 23a4bac
              
                remove unused var
              
              
                nv-anants 8d95a4c
              
                revert back backend part
              
              
                nv-anants c5b51c4
              
                Revert "revert back backend part"
              
              
                nv-anants a95c0c3
              
                Revert "remove unused var"
              
              
                nv-anants c8c28db
              
                Revert "refactor"
              
              
                nv-anants 92c4bad
              
                fix: run tests in parallel, re-enable cleanup
              
              
                mohammedabdulwahhab 72d3980
              
                fix: build and push images for backends
              
              
                mohammedabdulwahhab 3a71653
              
                fix: build and push images for backends
              
              
                mohammedabdulwahhab 83c7c82
              
                fix: build and push images for backends
              
              
                mohammedabdulwahhab a5eabe1
              
                fix: add more profiles
              
              
                mohammedabdulwahhab 3b3e27b
              
                fix: add more profiles
              
              
                mohammedabdulwahhab 1e61ebc
              
                fix: add more profiles
              
              
                mohammedabdulwahhab 28b1a2d
              
                fix: pull main
              
              
                mohammedabdulwahhab e07f5cf
              
                Merge branch 'main' into dtokarev-e2e
              
              
                nv-anants 92aa1f8
              
                fix namespace assignment
              
              
                nv-anants 6cbd271
              
                remove sleep in cleanup
              
              
                nv-anants 9e64dad
              
                revert all commented parts
              
              
                nv-anants 0661846
              
                skip on doc only changes
              
              
                nv-anants 5d62ffb
              
                precommit
              
              
                nv-anants 404056a
              
                missed comments
              
              
                nv-anants 2715603
              
                Merge branch 'main' into dtokarev-e2e
              
              
                nv-anants a36d11a
              
                up the timneoutt
              
              
                nv-anants 550a0bf
              
                make checks non blocking
              
              
                nv-anants 8b61754
              
                Merge branch 'main' into dtokarev-e2e
              
              
                nv-anants f1ba94b
              
                Merge branch 'main' into dtokarev-e2e
              
              
                nv-anants File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
          Some comments aren't visible on the classic Files Changed page.
        
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| description: 'Tag and Push Docker Images' | ||
| inputs: | ||
| local_image: | ||
| description: 'Local Image Name:Tag' | ||
| required: true | ||
| push_tag: | ||
| description: 'Target Tag for ECR' | ||
| required: false | ||
| aws_push: | ||
| description: 'Push to AWS Boolean' | ||
| required: false | ||
| default: 'false' | ||
| aks_push: | ||
| description: 'Push to AKS Boolean' | ||
| required: false | ||
| default: 'false' | ||
|  | ||
| aws_account_id: | ||
| description: 'AWS Account ID' | ||
| required: false | ||
| aws_default_region: | ||
| description: 'AWS Default Region' | ||
| required: false | ||
| aws_access_key_id: | ||
| description: 'AWS Access Key ID' | ||
| required: false | ||
| aws_secret_access_key: | ||
| description: 'AWS Secret Access Key' | ||
| required: false | ||
| azure_acr_hostname: | ||
| description: 'Azure ACR hostname' | ||
| required: false | ||
| azure_acr_user: | ||
| description: 'Azure ACR user' | ||
| required: false | ||
| azure_acr_password: | ||
| description: 'Azure ACR password' | ||
| required: false | ||
|  | ||
| env: | ||
| AWS_ACCESS_KEY_ID: ${{ inputs.aws_access_key_id || '' }} | ||
| AWS_SECRET_ACCESS_KEY: ${{ inputs.aws_secret_access_key || '' }} | ||
| AWS_REGION: ${{ inputs.aws_default_region || '' }} | ||
| AWS_ACCOUNT_ID: ${{ inputs.aws_account_id || '' }} | ||
| AWS_PUSH_TAG: ${{ inputs.aws_push_tag || '' }} | ||
| AWS_PUSH: ${{ inputs.AWS_PUSH }} | ||
|  | ||
| AKS_USER: ${{ inputs.azure_acr_user || '' }} | ||
| AKS_PASSWORD: ${{ inputs.azure_acr_password || '' }} | ||
| AKS_HOSTNAME: ${{ inputs.azure_acr_hostname || '' }} | ||
| AKS_PUSH_TAG: ${{ inputs.aks_push_tag || '' }} | ||
| AKS_PUSH: ${{ inputs.AKS_PUSH }} | ||
|  | ||
|         
                  nv-anants marked this conversation as resolved.
              Outdated
          
            Show resolved
            Hide resolved | ||
| LOCAL_IMAGE: ${{ inputs.local_image || '' }} | ||
|  | ||
| outputs: | ||
| image_tag: | ||
| description: 'Image Tag' | ||
| value: ${{ inputs.push_tag }} | ||
|  | ||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
| # - name: Install tools | ||
| - name: ECR Login | ||
| if: ${{ env.AWS_PUSH == 'true' }} | ||
| env: | ||
| ECR_HOSTNAME: ${AWS_ACCOUNT_ID}.dkr.ecr.${AWS_REGION}.amazonaws.com | ||
| run: | | ||
| aws ecr get-login-password --region ${AWS_REGION} | docker login --username AWS --password-stdin ${ECR_HOSTNAME} | ||
| - name: ACR Login | ||
|         
                  nv-anants marked this conversation as resolved.
              Outdated
          
            Show resolved
            Hide resolved | ||
| if: ${{ env.AKS_PUSH == 'true' }} | ||
| run: | | ||
| - name: ECR Tag and Push | ||
|         
                  nv-anants marked this conversation as resolved.
              Show resolved
            Hide resolved | ||
| if: ${{ env.AWS_PUSH == 'true' }} | ||
| env: | ||
| ECR_HOSTNAME: ${AWS_ACCOUNT_ID}.dkr.ecr.${AWS_REGION}.amazonaws.com | ||
| run: | | ||
| docker tag ${LOCAL_IMAGE} ${ECR_HOSTNAME}/${AWS_PUSH_TAG} | ||
| docker push ${AWS_PUSH_TAG} | ||
| - name: ACR Tag and Push | ||
| if: ${{ env.AKS_PUSH == 'true' }} | ||
| run: | | ||
| docker tag ${LOCAL_IMAGE} ${AKS_HOSTNAME}/${AKS_PUSH_TAG} | ||
| docker push ${AKS_PUSH_TAG} | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.