-
Notifications
You must be signed in to change notification settings - Fork 693
chore(CODEOWNERS): Manage permissions by team not by individual #3142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Manually adding and removing people from these lists doesn't really scale. Signed-off-by: Graham King <[email protected]>
WalkthroughConsolidates CODEOWNERS entries by replacing long per-user owner lists with team-based ownership for specific directories: container, examples (including multimodal), and planner-related paths (components/planner, benchmarks/profiler, tests/planner). Other paths remain unchanged. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CODEOWNERS (1)
29-31: *Planner rules override global .rs; include Rust team if needed.These directory rules supersede the earlier “*.rs → rust team.” If any Rust files live under these paths, Rust owners won’t be auto‑requested. Add the Rust team if that’s unintended.
-/components/planner/ @ai-dynamo/python-codeowners @ai-dynamo/Devops +/components/planner/ @ai-dynamo/python-codeowners @ai-dynamo/dynamo-rust-codeowners @ai-dynamo/Devops -/benchmarks/profiler/ @ai-dynamo/python-codeowners @ai-dynamo/Devops +/benchmarks/profiler/ @ai-dynamo/python-codeowners @ai-dynamo/dynamo-rust-codeowners @ai-dynamo/Devops -/tests/planner/ @ai-dynamo/python-codeowners @ai-dynamo/Devops +/tests/planner/ @ai-dynamo/python-codeowners @ai-dynamo/dynamo-rust-codeowners @ai-dynamo/Devops
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CODEOWNERS(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build and Test - vllm
- GitHub Check: Build and Test - dynamo
🔇 Additional comments (2)
CODEOWNERS (2)
13-13: Team-based owners for /container/ — LGTM; confirm intent on broad language coverage.Change aligns with the PR goal. Please confirm you want both Rust and Python teams pinged for all container changes; if not, consider narrowing by subdirs (e.g., /container/python/, /container/rust/) or keeping Devops only.
19-21: Replace individual owners under /examples/*/deploy/ with team(s); confirm team slugs & repo perms
- CODEOWNERS (lines 19–21): line 20 lists individual users — switch to team ownership (examples: /examples/*/deploy/ -> @ai-dynamo/Devops or @ai-dynamo/Devops @ai-dynamo/python-codeowners @ai-dynamo/dynamo-rust-codeowners).
- Verification failed: the provided gh API check returned 404 for ai-dynamo team "devops"; cannot confirm team slugs or repo write permissions. Confirm exact team slugs and that those teams have write access to ai-dynamo/dynamo before applying the change.
Now 100% individual free! Signed-off-by: Graham King <[email protected]>
nv-anants
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love the branch name!! ❤️
Manually adding and removing people from these lists doesn't really scale.
Summary by CodeRabbit