fix: shellcheck errors

[csicar]

Overview:

This MR improves the ./container/*.sh scripts.

Details:

The changes include:

• Fix typo
• Use proper /usr/bin/env interpreter
• Quote variable where applicable
• Remove double negation in if statements

Where should the reviewer start?

Take a look at ./container/*.sh

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

no related issue was found, but e.g. on NixOS, you cannot run these scripts, since bash is not located under /bin/bash

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[github-actions]

👋 Hi csicar! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

[rmccorm4]

LGTM overall, just a few minor comments. Thanks for the change! We can consider adding shellcheck to our automation to avoid this being a recurring change.

[csicar]

We can consider adding shellcheck to our automation to avoid this being a recurring change.

The way the ./container/*.sh scripts work at the moment, shellcheck violations are required: docker run ... ${GPU_STRING} for example required that the GPU_STRING is expanded to work correctly. So we would need to ignore the shellcheck warning explicitly there. A Github Action is available, so integrating it should not be that hard

[csicar]

Before this get's out-of-date. I think it might make sense to merge this. Adding a CI-Stage can probably be a separate PR

[harryskim]

Please target 0.2.0 release.