fix: devcontainer.json typo from b6b3a767c

[keivenchang]

Overview:

Fix typo in devcontainer.json image name from "dynamo:latest-vllm-dev" to "dynamo:latest-vllm-local-dev".

Details:

• Corrected image name in .devcontainer/devcontainer.json to match the actual Docker image name
• This fixes the devcontainer configuration to properly reference the local development image

Where should the reviewer start?

.devcontainer/devcontainer.json - single line change to fix the image name typo

Related Issues:

Summary by CodeRabbit

• Chores
  • Updated development container image to dynamo:latest-vllm-local-dev.

[Copilot]

Pull Request Overview

This PR fixes a typo in the devcontainer configuration by correcting the Docker image name from "dynamo:latest-vllm-dev" to "dynamo:latest-vllm-local-dev".

• Corrected image name to properly reference the local development Docker image

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[coderabbitai]

Walkthrough

The dev container configuration updates the Docker image reference in .devcontainer/devcontainer.json from dynamo:latest-vllm-dev to dynamo:latest-vllm-local-dev. No other settings are changed.

Changes

Cohort / File(s)	Summary
Devcontainer config .devcontainer/devcontainer.json	Update "image" from "dynamo:latest-vllm-dev" to "dynamo:latest-vllm-local-dev".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• fix: dev target needs special permission, now VLLM version works for run.sh and Dev Container #2822 — Introduces/auto-detects "-local-dev" images and Dev Container behavior, aligning with switching to "latest-vllm-local-dev".
• build: default to using dev instead of local-dev for vllm build #2834 — Also modifies the same devcontainer image tag for the vLLM environment, indicating coordinated image tag updates.

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title clearly states the primary change by indicating a fix to a typo in the devcontainer.json file, which matches the one-line edit in the changeset, and succinctly conveys the intent of the pull request. Including the commit SHA does not mislead about the content, though it is not essential to understanding the change. Overall, the title remains specific to the main change and provides sufficient context for peers reviewing the history.
Description Check	✅ Passed	The pull request description follows the repository template by providing an Overview that describes the change, a Details section outlining exactly what was modified, and guidance on where to start reviewing. Although the Related Issues section is present but empty, this is acceptable for a change that does not close or reference a tracked issue. The description is clear, complete, and aligns with the project’s conventions.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

Poem

A nibble of config, a carrot-sized tweak,
Swap the tag, hop along—no bugs to seek.
Local dev burrow, warm and bright,
Pull the right image, code takes flight.
Thump-thump, merge done—what a delight! 🥕🐇

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

.devcontainer/devcontainer.json (1)

10-10: Nit: clarify the inline comment.

Say “local dev image” to match the new tag.

-    "image": "dynamo:latest-vllm-local-dev", // Use the latest VLLM dev image
+    "image": "dynamo:latest-vllm-local-dev", // Use the latest VLLM local dev image

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eaa0338 and 80da5f1.

📒 Files selected for processing (1)

• .devcontainer/devcontainer.json (1 hunks)

🧰 Additional context used

🧠 Learnings (5)

📓 Common learnings

Learnt from: keivenchang
PR: ai-dynamo/dynamo#2797
File: .devcontainer/devcontainer.json:12-12
Timestamp: 2025-08-30T20:43:10.091Z
Learning: In the dynamo project, devcontainer.json files use templated container names (like "dynamo-vllm-devcontainer") that are automatically processed by the copy_devcontainer.sh script to generate framework-specific configurations with unique names, preventing container name collisions.

Learnt from: keivenchang
PR: ai-dynamo/dynamo#2797
File: .devcontainer/devcontainer.json:12-12
Timestamp: 2025-08-30T20:43:10.091Z
Learning: In the dynamo project's devcontainer setup, hard-coded container names in devcontainer.json files serve as templates that are automatically processed by the copy_devcontainer.sh script to generate framework-specific configurations with unique names, preventing container name collisions.

Learnt from: keivenchang
PR: ai-dynamo/dynamo#2797
File: container/Dockerfile:437-449
Timestamp: 2025-08-30T20:43:49.632Z
Learning: In the dynamo project's devcontainer setup, the team prioritizes consistency across framework-specific Dockerfiles (like container/Dockerfile, container/Dockerfile.vllm, etc.) by mirroring their structure, even when individual optimizations might be possible, to maintain uniformity in the development environment setup.

📚 Learning: 2025-08-30T20:43:10.091Z

Learnt from: keivenchang
PR: ai-dynamo/dynamo#2797
File: .devcontainer/devcontainer.json:12-12
Timestamp: 2025-08-30T20:43:10.091Z
Learning: In the dynamo project, devcontainer.json files use templated container names (like "dynamo-vllm-devcontainer") that are automatically processed by the copy_devcontainer.sh script to generate framework-specific configurations with unique names, preventing container name collisions.

Applied to files:

• .devcontainer/devcontainer.json

📚 Learning: 2025-08-30T20:43:10.091Z

Learnt from: keivenchang
PR: ai-dynamo/dynamo#2797
File: .devcontainer/devcontainer.json:12-12
Timestamp: 2025-08-30T20:43:10.091Z
Learning: In the dynamo project's devcontainer setup, hard-coded container names in devcontainer.json files serve as templates that are automatically processed by the copy_devcontainer.sh script to generate framework-specific configurations with unique names, preventing container name collisions.

Applied to files:

• .devcontainer/devcontainer.json

📚 Learning: 2025-08-30T20:43:49.632Z

Learnt from: keivenchang
PR: ai-dynamo/dynamo#2797
File: container/Dockerfile:437-449
Timestamp: 2025-08-30T20:43:49.632Z
Learning: In the dynamo project's devcontainer setup, the team prioritizes consistency across framework-specific Dockerfiles (like container/Dockerfile, container/Dockerfile.vllm, etc.) by mirroring their structure, even when individual optimizations might be possible, to maintain uniformity in the development environment setup.

Applied to files:

• .devcontainer/devcontainer.json

📚 Learning: 2025-09-03T01:10:12.599Z

Learnt from: keivenchang
PR: ai-dynamo/dynamo#2822
File: container/Dockerfile.vllm:343-352
Timestamp: 2025-09-03T01:10:12.599Z
Learning: In the dynamo project's local-dev Docker targets, USER_UID and USER_GID build args are intentionally left without default values to force explicit UID/GID mapping during build time, preventing file permission issues in local development environments where container users need to match host user permissions for mounted volumes.

Applied to files:

• .devcontainer/devcontainer.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build and Test - dynamo

🔇 Additional comments (1)

.devcontainer/devcontainer.json (1)

10-10: LGTM: image tag corrected to local dev variant.

This aligns the devcontainer with the intended vLLM local dev image.