Skip to content

Conversation

@saturley-hall
Copy link
Member

@saturley-hall saturley-hall commented Sep 8, 2025

Overview:

pynvml is deprecated and is breaking CI. It is recommended to be replaced with nvidia-ml-py

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes OPS-995

Summary by CodeRabbit

  • Chores

    • Replaced deprecated GPU monitoring dependency with a maintained alternative to improve compatibility and reliability during installation and runtime.
    • Removed obsolete dependency to reduce deprecation risks.
  • Tests

    • Suppressed a noisy deprecation warning in test runs to produce cleaner CI output.
  • Notes

    • No user-facing features or application logic changed.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 8, 2025

Walkthrough

Dependencies updated by replacing pynvml with nvidia-ml-py and removing a license header in requirements. Test configuration updated to suppress a pynvml deprecation FutureWarning in PyTest via pyproject.toml. No runtime code or public API changes.

Changes

Cohort / File(s) Summary of Changes
Dependency management
container/deps/requirements.txt
Removed license header block; added nvidia-ml-py==13.580.65; removed pynvml.
Test warning configuration
pyproject.toml
Added PyTest filterwarnings entry to ignore FutureWarning about pynvml deprecation (temporary suppression).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks (2 passed, 1 warning)

❌ Failed Checks (1 warning)
Check Name Status Explanation Resolution
Description Check ⚠️ Warning The current description provides an Overview and a Related Issues section but omits the required Details and Where should the reviewer start sections from the repository’s template, and the Related Issues entry does not follow the “closes GitHub issue: #xxx” format. Add the “Details” section describing the specific dependency replacement and test configuration changes, include a “Where should the reviewer start?” section pointing to the modified files, and update the Related Issues line to match the template (e.g., “closes GitHub issue: #OPS-995”).
✅ Passed Checks (2 passed)
Check Name Status Explanation
Title Check ✅ Passed The title clearly and concisely summarizes the primary issue by indicating that CI is broken due to the deprecated pynvml dependency, which is exactly what the pull request addresses.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Poem

In the burrow of deps I hop with glee,
Swapped old NVML for a newer tree.
Hush, FutureWarning—soft as moss,
Tests keep calm, no flakes, no loss.
Thump-thump! My paws approve this tune—
Cleaner trails beneath the moon. 🐇✨

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  - Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.
  - Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right fix? I see the pynvml related failure still happening on this PR's check: https://github.com/ai-dynamo/dynamo/actions/runs/17555361883/job/49858015783?pr=2926#step:8:680

Signed-off-by: alec-flowers <[email protected]>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
container/deps/requirements.txt (1)

19-19: Document the rationale and lock intent next to the pin.

Add a short inline comment so future updaters know this replaces the deprecated wheel and that the import name is still pynvml.

-nvidia-ml-py==13.580.65
+nvidia-ml-py==13.580.65  # replaces deprecated `pynvml`; module import remains `pynvml`
pyproject.toml (1)

156-156: Narrow the warning filter to just the pynvml module to avoid masking unrelated FutureWarnings.

Current pattern-wide ignore can hide similarly worded messages. Scope the filter by module to keep the global error policy effective elsewhere. Keep the “temporary” note.

-    "ignore:The pynvml package is deprecated.*:FutureWarning", # Ignore pynvml deprecation warning, temporary until upstream library updates to nvidia-ml-py
+    "ignore:The pynvml package is deprecated.*:FutureWarning:pynvml", # Temporary: ignore only when originating from the pynvml module
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1477f6e and 2103bfc.

📒 Files selected for processing (2)
  • container/deps/requirements.txt (1 hunks)
  • pyproject.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Build and Test - vllm
  • GitHub Check: Mirror Repository to GitLab
  • GitHub Check: Build and Test - dynamo
🔇 Additional comments (3)
container/deps/requirements.txt (2)

19-19: Replace pynvml with nvidia-ml-py — good, API remains importable as pynvml.

This aligns with NVIDIA’s deprecation guidance and should unblock CI without runtime code changes.


19-19: Compatibility Verified for nvidia-ml-py Pin
nvidia-ml-py 13.580.65 is published on PyPI as a universal py3-none-any.whl and source tarball, covering Python 3.10–3.12, and no imports or dependencies on pynvml remain in the codebase or lock files.

pyproject.toml (1)

124-157: Skip adding an nvml optional extra—no pynvml imports detected
Ripgrep search across all Python files (excluding tests, vendor, and third_party) found no unconditional import pynvml or from pynvml usages; no runtime NVML dependency exists.

@alec-flowers alec-flowers merged commit fda1efe into main Sep 8, 2025
12 of 13 checks passed
@alec-flowers alec-flowers deleted the harriosn/fix-deprecated-pynvml branch September 8, 2025 22:05
saturley-hall added a commit that referenced this pull request Sep 9, 2025
Signed-off-by: Harrison Saturley-Hall <[email protected]>
Signed-off-by: alec-flowers <[email protected]>
Co-authored-by: alec-flowers <[email protected]>
Signed-off-by: Harrison King Saturley-Hall <[email protected]>
saturley-hall added a commit that referenced this pull request Sep 9, 2025
Signed-off-by: Harrison Saturley-Hall <[email protected]>
Signed-off-by: alec-flowers <[email protected]>
Signed-off-by: Harrison King Saturley-Hall <[email protected]>
Co-authored-by: alec-flowers <[email protected]>
indrajit96 pushed a commit that referenced this pull request Sep 9, 2025
Signed-off-by: Harrison Saturley-Hall <[email protected]>
Signed-off-by: alec-flowers <[email protected]>
Co-authored-by: alec-flowers <[email protected]>
Signed-off-by: Indrajit Bhosale <[email protected]>
indrajit96 pushed a commit that referenced this pull request Sep 9, 2025
Signed-off-by: Harrison Saturley-Hall <[email protected]>
Signed-off-by: alec-flowers <[email protected]>
Co-authored-by: alec-flowers <[email protected]>
tedzhouhk pushed a commit that referenced this pull request Sep 10, 2025
Signed-off-by: Harrison Saturley-Hall <[email protected]>
Signed-off-by: alec-flowers <[email protected]>
Co-authored-by: alec-flowers <[email protected]>
Signed-off-by: hongkuanz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants