Skip to content

fix: hello world deployment liveness probe and match message responses with readme #2634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2025
Merged

fix: hello world deployment liveness probe and match message responses with readme #2634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/runtime/hello_world/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ async def worker(runtime: DistributedRuntime):
try:
# Issue request and process the stream
idx += 1
stream = await client.generate(f"Query[{idx}] Hello world")
stream = await client.generate("world,sun,moon,star")
async for response in stream:
print(response.data())
# Reset backoff on successful iteration
Expand Down
5 changes: 3 additions & 2 deletions examples/runtime/hello_world/deploy/hello_world.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ kind: DynamoGraphDeployment
metadata:
name: hello-world
spec:
backendFramework: vllm
services:
Frontend:
livenessProbe:
Expand Down Expand Up @@ -60,7 +61,7 @@ spec:
command:
- /bin/sh
- -c
- 'grep "Serving endpoint" /tmp/hello_world.log'
- "exit 0"
initialDelaySeconds: 60
periodSeconds: 60
timeoutSeconds: 30
Expand All @@ -83,4 +84,4 @@ spec:
- /bin/sh
- -c
args:
- python3 hello_world.py 2>&1 | tee /tmp/hello_world.log
- python3 hello_world.py
Loading