Skip to content

chore: Update comment and ref for vllm #2527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: Update comment and ref for vllm #2527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions container/Dockerfile.vllm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,8 @@ ARG RUNTIME_IMAGE_TAG="12.8.1-runtime-ubuntu24.04"
ARG VLLM_REF="77a6bf07aedf132aad2b6719f6d87abc5d3311ab"
ARG TORCH_BACKEND="cu128"

# Match 0.10.0 vLLM release
# https://github.com/vllm-project/vllm/releases/tag/v0.10.0
# Pinned to commit before https://github.com/deepseek-ai/DeepGEMM/pull/112 for DeepGEMM which seems to break on H100:
# "RuntimeError: Failed: CUDA runtime error csrc/jit/kernel_runtime.hpp:108 '98'"
# Match 0.10.1 vLLM release
# https://github.com/vllm-project/vllm/releases/tag/v0.10.1
Comment on lines +19 to +20
Copy link
Contributor

@coderabbitai coderabbitai bot Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Confirm commit/tag alignment and annotate for traceability

Good to document the target release. Since VLLM_REF (Line 16) is pinned to a commit, please verify that 77a6bf07aedf132aad2b6719f6d87abc5d3311ab is exactly the commit for v0.10.1, and consider annotating the commit in the comment for quicker traceability.

If you want to make this explicit, you could add a small comment:

 # Match 0.10.1 vLLM release
 # https://github.com/vllm-project/vllm/releases/tag/v0.10.1
+# VLLM_REF pinned to commit for v0.10.1
+# 77a6bf07aedf132aad2b6719f6d87abc5d3311ab

Also, please sanity-check DEEPGEMM_REF and FLASHINF_REF compatibility with v0.10.1 (they are unchanged). If there are known pairings for this vLLM release, capturing them in a short comment helps future bumps.

🌐 Web query:

What commit hash does the vLLM GitHub tag v0.10.1 point to?

💡 Result:

The v0.10.1 tag points to commit aab549870df50edf0512f0a59b574f692f546465 (short: aab5498). (github.com)

Citations:

Align VLLM_REF with the v0.10.1 tag commit
The Dockerfile currently pins VLLM_REF to 77a6bf07aedf132aad2b6719f6d87abc5d3311ab, but the GitHub v0.10.1 tag actually points to commit aab549870df50edf0512f0a59b574f692f546465. Please update the ref and annotate it for traceability:

 # Match 0.10.1 vLLM release
 # https://github.com/vllm-project/vllm/releases/tag/v0.10.1
-# VLLM_REF pinned to commit for v0.10.1
-# 77a6bf07aedf132aad2b6719f6d87abc5d3311ab
+VLLM_REF=aab549870df50edf0512f0a59b574f692f546465
+# VLLM_REF pinned to commit for v0.10.1 (aab549870df50edf0512f0a59b574f692f546465)

• After updating, please also sanity-check that your DEEPGEMM_REF and FLASHINF_REF remain compatible with this v0.10.1 commit.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Match 0.10.1 vLLM release
# https://github.com/vllm-project/vllm/releases/tag/v0.10.1
# Match 0.10.1 vLLM release
# https://github.com/vllm-project/vllm/releases/tag/v0.10.1
VLLM_REF=aab549870df50edf0512f0a59b574f692f546465
# VLLM_REF pinned to commit for v0.10.1 (aab549870df50edf0512f0a59b574f692f546465)
🤖 Prompt for AI Agents 
In container/Dockerfile.vllm around lines 19 to 20, VLLM_REF is pinned to commit
77a6bf07aedf132aad2b6719f6d87abc5d3311ab but should point to the v0.10.1 tag
commit aab549870df50edf0512f0a59b574f692f546465; update the VLLM_REF value to
aab549870df50edf0512f0a59b574f692f546465 and add a brief comment explaining this
maps to GitHub v0.10.1 for traceability, then rebuild or re-run any local docker
steps to verify no build errors and sanity-check DEEPGEMM_REF and FLASHINF_REF
(update them if they are known incompatible) by ensuring their commits or tags
are compatible with v0.10.1 and adjusting pins or comments accordingly.

ARG DEEPGEMM_REF="f85ec64"
ARG FLASHINF_REF="v0.2.8rc1"

Expand Down
2 changes: 0 additions & 2 deletions container/deps/vllm/install_vllm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,6 @@ git checkout $DEEPGEMM_REF # Pin Version
sed -i 's|[email protected]:|https://github.com/|g' .gitmodules
git submodule sync --recursive
git submodule update --init --recursive

# command for 03d0be3
python setup.py install

# new install command for post 03d0be3
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ trtllm =[
vllm = [
"uvloop",
"nixl<=0.4.1",
"vllm==0.10.0",
{ git = "https://github.com/vllm-project/vllm.git", rev = "77a6bf07aedf132aad2b6719f6d87abc5d3311ab" },
Copy link
Contributor

@nv-anants nv-anants Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we cannot use URLs in wheels dependencies, pypi wont allow us to publish python wheels which pull deps from URL

]

sglang = [
Expand Down
Loading