Skip to content

feat: LLM metrics for non-streaming requests in frontend #2427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2025
Merged

feat: LLM metrics for non-streaming requests in frontend #2427

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d2323e
feat: metrics for non-streaming
tedzhouhk Aug 13, 2025
a42dafb
use inspect instead of map
tedzhouhk Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions lib/llm/src/http/service/openai.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,11 @@ async fn completions(

Ok(sse_stream.into_response())
} else {
// TODO: report ISL/OSL for non-streaming requests
// Tap the stream to collect metrics for non-streaming requests without altering items
let stream = stream.inspect(move |response| {
process_metrics_only(response, &mut response_collector);
});

let response = NvCreateCompletionResponse::from_annotated_stream(stream)
.await
.map_err(|e| {
Expand Down Expand Up @@ -515,7 +519,10 @@ async fn chat_completions(

Ok(sse_stream.into_response())
} else {
// TODO: report ISL/OSL for non-streaming requests
let stream = stream.inspect(move |response| {
process_metrics_only(response, &mut response_collector);
});

let response = NvCreateChatCompletionResponse::from_annotated_stream(stream)
.await
.map_err(|e| {
Expand Down Expand Up @@ -911,6 +918,17 @@ impl<T> From<Annotated<T>> for EventConverter<T> {
}
}

fn process_metrics_only<T>(
annotated: &Annotated<T>,
response_collector: &mut ResponseMetricCollector,
) {
// update metrics
if let Ok(Some(metrics)) = LLMMetricAnnotation::from_annotation(annotated) {
response_collector.observe_current_osl(metrics.output_tokens);
response_collector.observe_response(metrics.input_tokens, metrics.chunk_tokens);
}
}

fn process_event_converter<T: Serialize>(
annotated: EventConverter<T>,
response_collector: &mut ResponseMetricCollector,
Expand Down
Loading