Skip to content

Conversation

@ishandhanani
Copy link
Contributor

@ishandhanani ishandhanani commented Aug 13, 2025

Summary by CodeRabbit

  • Documentation

    • Updated Docker build example to reference a newer SGLANG image tag.
  • Chores

    • Bumped container build dependencies to newer versions of SGLANG and NIXL.
    • Updated CUDA-targeted image variants used during builds (including examples with cu126 and cu129).

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 13, 2025

Walkthrough

Bumps version arguments for SGLANG and NIXL in container/Dockerfile.sglang-wideep and updates the corresponding SGLANG image tag in the related documentation example. No other build steps or logic changed.

Changes

Cohort / File(s) Summary of Changes
Docs: SGLANG image tag
components/backends/sglang/docs/dsr1-wideep-gb200.md
Updated docker build example: SGLANG_IMAGE_TAG from v0.4.9.post6-cu128-gb200 to v0.5.0rc0-cu129-gb200.
Docker build args: SGLANG & NIXL
container/Dockerfile.sglang-wideep
Updated ARGs: SGLANG_IMAGE_TAG v0.4.10-cu126 → v0.5.0rc0-cu126; NIXL_TAG 0.4.1 → 0.5.0. Base image and checkout reflect new tags; no other changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

I nudge the tags, hop-hop—no fuss,
New bytes aboard our versioned bus.
Docker hums, the carrots glow,
RC winds begin to blow.
Nixl blooms to five-point-oh—
A rabbit signs: “Ship it, go!” 🥕🚀


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
container/Dockerfile.sglang-wideep (1)

24-24: Confirm UCX compatibility & pin NIXL commit

We’ve verified that 0.5.0 exists at commit 4d0fe0206119ea40bd65fe7db83e352983df4efe and the recent release notes don’t indicate any UCX version bump. To be safe:

  • Test a full MODE=hopper build against UCX v1.19.x to ensure nothing has drifted.
  • If stability is critical, pin to the exact NIXL commit SHA to guard against tag retags.

Suggested diff:

- ARG NIXL_TAG="0.5.0"
+ ARG NIXL_TAG="0.5.0"
+ # For immutable dependency resolution:
+ # ARG NIXL_TAG_SHA="4d0fe0206119ea40bd65fe7db83e352983df4efe"-   cd /opt/nixl && git checkout $NIXL_TAG && \
+   cd /opt/nixl && git checkout ${NIXL_TAG_SHA:-$NIXL_TAG} && \
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b87c89 and 9aca794.

📒 Files selected for processing (2)
  • components/backends/sglang/docs/dsr1-wideep-gb200.md (1 hunks)
  • container/Dockerfile.sglang-wideep (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Mirror Repository to GitLab
  • GitHub Check: pre-merge-rust (.)
  • GitHub Check: pre-merge-rust (lib/bindings/python)
  • GitHub Check: Build and Test - dynamo
🔇 Additional comments (1)
container/Dockerfile.sglang-wideep (1)

16-16: Base image v0.5.0rc0-cu126 verified; dependencies compatible

  • Docker Hub tag v0.5.0rc0-cu126 (and optional v0.5.0rc0-cu129-gb200) exists.
  • sglang-router==0.1.5 has no sglang version constraint in its PyPI metadata.
  • genai-perf lists no sglang dependency in its runtime requirements.

@ishandhanani ishandhanani merged commit ebc84d6 into main Aug 13, 2025
15 checks passed
@ishandhanani ishandhanani deleted the ishan/up branch August 13, 2025 04:54
hhzhang16 pushed a commit that referenced this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants