-
Notifications
You must be signed in to change notification settings - Fork 690
chore: update wideep dockerfile for sgl to newest rel #2422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughBumps version arguments for SGLANG and NIXL in container/Dockerfile.sglang-wideep and updates the corresponding SGLANG image tag in the related documentation example. No other build steps or logic changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
container/Dockerfile.sglang-wideep (1)
24-24: Confirm UCX compatibility & pin NIXL commitWe’ve verified that
0.5.0exists at commit4d0fe0206119ea40bd65fe7db83e352983df4efeand the recent release notes don’t indicate any UCX version bump. To be safe:
- Test a full
MODE=hopperbuild against UCX v1.19.x to ensure nothing has drifted.- If stability is critical, pin to the exact NIXL commit SHA to guard against tag retags.
Suggested diff:
- ARG NIXL_TAG="0.5.0" + ARG NIXL_TAG="0.5.0" + # For immutable dependency resolution: + # ARG NIXL_TAG_SHA="4d0fe0206119ea40bd65fe7db83e352983df4efe" … - cd /opt/nixl && git checkout $NIXL_TAG && \ + cd /opt/nixl && git checkout ${NIXL_TAG_SHA:-$NIXL_TAG} && \
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
components/backends/sglang/docs/dsr1-wideep-gb200.md(1 hunks)container/Dockerfile.sglang-wideep(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Mirror Repository to GitLab
- GitHub Check: pre-merge-rust (.)
- GitHub Check: pre-merge-rust (lib/bindings/python)
- GitHub Check: Build and Test - dynamo
🔇 Additional comments (1)
container/Dockerfile.sglang-wideep (1)
16-16: Base image v0.5.0rc0-cu126 verified; dependencies compatible
- Docker Hub tag
v0.5.0rc0-cu126(and optionalv0.5.0rc0-cu129-gb200) exists.sglang-router==0.1.5has nosglangversion constraint in its PyPI metadata.genai-perflists nosglangdependency in its runtime requirements.
Signed-off-by: Hannah Zhang <[email protected]>
Summary by CodeRabbit
Documentation
Chores